You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "smiklosovic (via GitHub)" <gi...@apache.org> on 2023/03/13 12:12:57 UTC
[GitHub] [cassandra] smiklosovic opened a new pull request, #2212: removed Hadoop code
smiklosovic opened a new pull request, #2212:
URL: https://github.com/apache/cassandra/pull/2212
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a diff in pull request #2212: CASSANDRA-18323 removed Hadoop code
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #2212:
URL: https://github.com/apache/cassandra/pull/2212#discussion_r1143663579
##########
test/simulator/main/org/apache/cassandra/simulator/debug/SelfReconcilingRandom.java:
##########
@@ -20,24 +20,29 @@
import java.util.function.Supplier;
+import org.agrona.collections.Long2LongHashMap;
import org.apache.cassandra.simulator.RandomSource;
-import org.hsqldb.lib.IntKeyLongValueHashMap;
import static org.apache.cassandra.simulator.SimulatorUtils.failWithOOM;
public class SelfReconcilingRandom implements Supplier<RandomSource>
{
- static class Map extends IntKeyLongValueHashMap
+ static class Map extends Long2LongHashMap
{
+ public Map(long missingValue)
+ {
+ super(missingValue);
+ }
+
public boolean put(int i, long v)
{
int size = this.size();
- super.addOrRemove((long)i, (long)v, (Object)null, (Object)null, false);
+ super.put(i, v);
return size != this.size();
}
}
- final Map map = new Map();
- long[] tmp = new long[1];
+
+ final Map map = new Map(Long.MIN_VALUE);
Review Comment:
nit: this is an internal type, so can make this the default constructor and do `super(Long.MIN_VALUE)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2212: CASSANDRA-18323 removed Hadoop code
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2212:
URL: https://github.com/apache/cassandra/pull/2212#discussion_r1133841928
##########
.build/cassandra-build-deps-template.xml:
##########
@@ -127,5 +127,9 @@
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-yaml</artifactId>
</dependency>
+ <dependency>
Review Comment:
This needs to be added because `org.apache.cassandra.simulator.debug.SelfReconcilingRandom` uses `import org.hsqldb.lib.IntKeyLongValueHashMap;` from this library. We were using this dependency already as it was among dependencies of Hadoop we removed in this patch so we need to cherry-pick this one only. Scope is `test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2212: CASSANDRA-18323 removed Hadoop code
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2212:
URL: https://github.com/apache/cassandra/pull/2212#discussion_r1133842713
##########
test/burn/org/apache/cassandra/transport/SimpleClientPerfTest.java:
##########
@@ -30,7 +30,7 @@
import java.util.stream.Collectors;
import com.google.common.util.concurrent.RateLimiter;
-import org.apache.commons.math.stat.descriptive.DescriptiveStatistics;
+import org.apache.commons.math3.stat.descriptive.DescriptiveStatistics;
Review Comment:
`org.apache.commons.math` is not there anymore, but commons.math3 is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2212: CASSANDRA-18323 removed Hadoop code
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2212:
URL: https://github.com/apache/cassandra/pull/2212#discussion_r1133842713
##########
test/burn/org/apache/cassandra/transport/SimpleClientPerfTest.java:
##########
@@ -30,7 +30,7 @@
import java.util.stream.Collectors;
import com.google.common.util.concurrent.RateLimiter;
-import org.apache.commons.math.stat.descriptive.DescriptiveStatistics;
+import org.apache.commons.math3.stat.descriptive.DescriptiveStatistics;
Review Comment:
`org.apache.commons.math` is not there anymore, but commons3 is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #2212: CASSANDRA-18323 removed Hadoop code
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #2212: CASSANDRA-18323 removed Hadoop code
URL: https://github.com/apache/cassandra/pull/2212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2212: CASSANDRA-18323 removed Hadoop code
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2212:
URL: https://github.com/apache/cassandra/pull/2212#discussion_r1133841928
##########
.build/cassandra-build-deps-template.xml:
##########
@@ -127,5 +127,9 @@
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-yaml</artifactId>
</dependency>
+ <dependency>
Review Comment:
This needs to be added because `org.apache.cassandra.simulator.debug.SelfReconcilingRandom` uses `import org.hsqldb.lib.IntKeyLongValueHashMap;` from this library. We were using this dependency already as it was among dependencies of Hadoop we removed in this patch so we need to cherry-pick this one only. Scope is `test`.
We can dedicate separate ticket to removing this library as well. It is rather suspicious we depend on hsqldb even it is in test scope. However, this ticket should just track the removal of Hadoop as such.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org