You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by pt...@apache.org on 2015/05/29 21:49:42 UTC
[5/9] storm git commit: Removing the unnecessary constructor argument.
Removing the unnecessary constructor argument.
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/7ca8e296
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/7ca8e296
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/7ca8e296
Branch: refs/heads/0.10.x-branch
Commit: 7ca8e296be9bee96f96a9cec1731623482fd633e
Parents: a633fe1
Author: Parth Brahmbhatt <br...@gmail.com>
Authored: Tue May 26 15:55:55 2015 -0700
Committer: Parth Brahmbhatt <br...@gmail.com>
Committed: Tue May 26 15:55:55 2015 -0700
----------------------------------------------------------------------
external/storm-jdbc/README.md | 2 +-
.../main/java/org/apache/storm/jdbc/mapper/SimpleJdbcMapper.java | 2 +-
.../java/org/apache/storm/jdbc/topology/AbstractUserTopology.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/7ca8e296/external/storm-jdbc/README.md
----------------------------------------------------------------------
diff --git a/external/storm-jdbc/README.md b/external/storm-jdbc/README.md
index 192be73..8595a39 100644
--- a/external/storm-jdbc/README.md
+++ b/external/storm-jdbc/README.md
@@ -65,7 +65,7 @@ hikariConfigMap.put("dataSource.password","password");
ConnectionProvider connectionProvider = new HikariCPConnectionProvider(map);
String tableName = "user_details";
-JdbcMapper simpleJdbcMapper = new SimpleJdbcMapper(tableName, map);
+JdbcMapper simpleJdbcMapper = new SimpleJdbcMapper(tableName, connectionProvider);
JdbcInsertBolt userPersistanceBolt = new JdbcInsertBolt(connectionProvider, simpleJdbcMapper)
.withTableName("user")
http://git-wip-us.apache.org/repos/asf/storm/blob/7ca8e296/external/storm-jdbc/src/main/java/org/apache/storm/jdbc/mapper/SimpleJdbcMapper.java
----------------------------------------------------------------------
diff --git a/external/storm-jdbc/src/main/java/org/apache/storm/jdbc/mapper/SimpleJdbcMapper.java b/external/storm-jdbc/src/main/java/org/apache/storm/jdbc/mapper/SimpleJdbcMapper.java
index 1ec5c74..c4005e3 100644
--- a/external/storm-jdbc/src/main/java/org/apache/storm/jdbc/mapper/SimpleJdbcMapper.java
+++ b/external/storm-jdbc/src/main/java/org/apache/storm/jdbc/mapper/SimpleJdbcMapper.java
@@ -34,7 +34,7 @@ public class SimpleJdbcMapper implements JdbcMapper {
private List<Column> schemaColumns;
- public SimpleJdbcMapper(String tableName, Map<String, Object> connectionProvideConfig, ConnectionProvider connectionProvider) {
+ public SimpleJdbcMapper(String tableName, ConnectionProvider connectionProvider) {
int queryTimeoutSecs = 30;
connectionProvider.prepare();
JdbcClient client = new JdbcClient(connectionProvider, queryTimeoutSecs);
http://git-wip-us.apache.org/repos/asf/storm/blob/7ca8e296/external/storm-jdbc/src/test/java/org/apache/storm/jdbc/topology/AbstractUserTopology.java
----------------------------------------------------------------------
diff --git a/external/storm-jdbc/src/test/java/org/apache/storm/jdbc/topology/AbstractUserTopology.java b/external/storm-jdbc/src/test/java/org/apache/storm/jdbc/topology/AbstractUserTopology.java
index 653f3d9..9df5a86 100644
--- a/external/storm-jdbc/src/test/java/org/apache/storm/jdbc/topology/AbstractUserTopology.java
+++ b/external/storm-jdbc/src/test/java/org/apache/storm/jdbc/topology/AbstractUserTopology.java
@@ -92,7 +92,7 @@ public abstract class AbstractUserTopology {
}
this.userSpout = new UserSpout();
- this.jdbcMapper = new SimpleJdbcMapper(TABLE_NAME, map, connectionProvider);
+ this.jdbcMapper = new SimpleJdbcMapper(TABLE_NAME, connectionProvider);
connectionProvider.cleanup();
Fields outputFields = new Fields("user_id", "user_name", "dept_name", "create_date");
List<Column> queryParamColumns = Lists.newArrayList(new Column("user_id", Types.INTEGER));