[GitHub] [kafka] OmniaGM commented on a change in pull request #10937: KAFKA-10587 Rename kafka-mirror-maker CLI command line arguments for KIP-629

[GitBox <gi...@apache.org>]

OmniaGM commented on a change in pull request #10937:
URL: https://github.com/apache/kafka/pull/10937#discussion_r662449984



##########
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##########
@@ -454,8 +454,8 @@ object MirrorMaker extends Logging with KafkaMetricsGroup {
       .ofType(classOf[java.lang.Integer])
       .defaultsTo(1)
 
-    val whitelistOpt = parser.accepts("whitelist",
-      "Whitelist of topics to mirror.")
+    val includeOpt = parser.accepts("include",

Review comment:
       I added it back and handled both. Now the command will have 
   ```
   --whitelist <String: Java regex          DEPRECATED, use --include instead;    
     (String)>                                ignored if --include specified. List
                                              of included topics to mirror. 
   --include <String: Java regex (String)>  List of included topics to mirror.    
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org