You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/11/11 05:39:03 UTC
[GitHub] [incubator-echarts] pissang commented on issue #11617: Add new
methods for List and fix #11616
pissang commented on issue #11617: Add new methods for List and fix #11616
URL: https://github.com/apache/incubator-echarts/pull/11617#issuecomment-552300653
Hi, I've leaved comments on the code.
Also the `min` `max` calculation is already in the https://github.com/apache/incubator-echarts/pull/11617/files#diff-ed976f176ba3ed927f196407ddc456a0L68 . I think the fix should be in the function `numCalculate`. And there is no need to copy all the data out of the `List` module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org