You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/08 14:35:03 UTC

[GitHub] [incubator-eventmesh] walterlife opened a new pull request, #1239: [#1091]add workflow/catalog grpc protocols

walterlife opened a new pull request, #1239:
URL: https://github.com/apache/incubator-eventmesh/pull/1239

   Fixes #1091 
   
   ### Motivation
   Applications can access the EventMesh Workflow/AysncAPI capabilities through the EventMesh SDK to fill the event governance capabilities
   
   ### Modifications
   add workflow/catalog protocol into eventmesh-common module
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] walterlife closed pull request #1239: [#1091]add workflow/catalog grpc protocols

Posted by GitBox <gi...@apache.org>.
walterlife closed pull request #1239: [#1091]add workflow/catalog grpc protocols
URL: https://github.com/apache/incubator-eventmesh/pull/1239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #1239: [#1091]add workflow/catalog grpc protocols

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #1239:
URL: https://github.com/apache/incubator-eventmesh/pull/1239#issuecomment-1241438297

   @walterlife please help to split the pr to two prs and associating the respective issues , namely workflow grpc protocol 、catalog grpc protocol, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1239: [#1091]add workflow/catalog grpc protocols

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1239:
URL: https://github.com/apache/incubator-eventmesh/pull/1239#issuecomment-1241410184

   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1239](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d201f7e) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/5101b39df2695b02924041603088601e4cb5903e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5101b39) will **decrease** coverage by `0.78%`.
   > The diff coverage is `0.25%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1239      +/-   ##
   ============================================
   - Coverage     11.19%   10.41%   -0.79%     
   - Complexity      758      763       +5     
   ============================================
     Files           421      432      +11     
     Lines         24580    26525    +1945     
     Branches       2683     2922     +239     
   ============================================
   + Hits           2752     2762      +10     
   - Misses        21565    23500    +1935     
     Partials        263      263              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/java/org/apache/eventmesh/common/Constants.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9Db25zdGFudHMuamF2YQ==) | `85.71% <ø> (ø)` | |
   | [...sh/common/protocol/catalog/protos/CatalogGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9DYXRhbG9nR3JwYy5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../protocol/catalog/protos/EventmeshCatalogGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9FdmVudG1lc2hDYXRhbG9nR3JwYy5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...mesh/common/protocol/catalog/protos/Operation.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9PcGVyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rotocol/catalog/protos/QueryOperationsRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9RdWVyeU9wZXJhdGlvbnNSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...otocol/catalog/protos/QueryOperationsResponse.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9RdWVyeU9wZXJhdGlvbnNSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ommon/protocol/catalog/protos/RegistryRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9SZWdpc3RyeVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...mmon/protocol/catalog/protos/RegistryResponse.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9SZWdpc3RyeVJlc3BvbnNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...rotocol/workflow/protos/EventmeshWorkflowGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC93b3JrZmxvdy9wcm90b3MvRXZlbnRtZXNoV29ya2Zsb3dHcnBjLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ommon/protocol/workflow/protos/ExecuteRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC93b3JrZmxvdy9wcm90b3MvRXhlY3V0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1239/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org