You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2012/10/17 18:06:02 UTC
[jira] [Created] (CASSANDRA-4824) Pack consistency level in binary
protocol
Sylvain Lebresne created CASSANDRA-4824:
-------------------------------------------
Summary: Pack consistency level in binary protocol
Key: CASSANDRA-4824
URL: https://issues.apache.org/jira/browse/CASSANDRA-4824
Project: Cassandra
Issue Type: Improvement
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Trivial
Fix For: 1.2.0 beta 2
Attachments: 4824.txt
Currently the binary protocol encode ConsistencyLevel values using a string. But especially now that we ship the consistency level with each query, it doesn't cost us much to use a simple short code, saving a bunch of bytes each time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4824) Pack consistency level in
binary protocol
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478007#comment-13478007 ]
Sylvain Lebresne commented on CASSANDRA-4824:
---------------------------------------------
bq. As long as we have an upgrade path should we add custom CL
We can do the same as with collections, i.e. have a specific code for the custom CL and have a string or something like that follow up. Shouldn't be a problem anyway.
> Pack consistency level in binary protocol
> -----------------------------------------
>
> Key: CASSANDRA-4824
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4824
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.2.0 beta 2
>
> Attachments: 4824.txt
>
>
> Currently the binary protocol encode ConsistencyLevel values using a string. But especially now that we ship the consistency level with each query, it doesn't cost us much to use a simple short code, saving a bunch of bytes each time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4824) Pack consistency level in
binary protocol
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477999#comment-13477999 ]
Jonathan Ellis commented on CASSANDRA-4824:
-------------------------------------------
As long as we have an upgrade path should we add custom CL (CASSANDRA-2338), LGTM.
> Pack consistency level in binary protocol
> -----------------------------------------
>
> Key: CASSANDRA-4824
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4824
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.2.0 beta 2
>
> Attachments: 4824.txt
>
>
> Currently the binary protocol encode ConsistencyLevel values using a string. But especially now that we ship the consistency level with each query, it doesn't cost us much to use a simple short code, saving a bunch of bytes each time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4824) Pack consistency level in binary
protocol
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne resolved CASSANDRA-4824.
-----------------------------------------
Resolution: Fixed
Reviewer: jbellis
Alright, committed, thanks
> Pack consistency level in binary protocol
> -----------------------------------------
>
> Key: CASSANDRA-4824
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4824
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.2.0 beta 2
>
> Attachments: 4824.txt
>
>
> Currently the binary protocol encode ConsistencyLevel values using a string. But especially now that we ship the consistency level with each query, it doesn't cost us much to use a simple short code, saving a bunch of bytes each time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4824) Pack consistency level in binary
protocol
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4824:
----------------------------------------
Attachment: 4824.txt
Attached trivial patch to do that.
> Pack consistency level in binary protocol
> -----------------------------------------
>
> Key: CASSANDRA-4824
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4824
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.2.0 beta 2
>
> Attachments: 4824.txt
>
>
> Currently the binary protocol encode ConsistencyLevel values using a string. But especially now that we ship the consistency level with each query, it doesn't cost us much to use a simple short code, saving a bunch of bytes each time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira