You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/08/09 16:29:51 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4671: Fix MSRV CI
tustvold opened a new pull request, #4671:
URL: https://github.com/apache/arrow-rs/pull/4671
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
https://github.com/apache/arrow-rs/pull/4653#issuecomment-1670155006
Bumping the MSRV because the most recent version of a crate has bumped their MSRV does not improve user UX, but prevents users on older versions from compiling. This PR tweaks the CI to avoid this
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4671: Fix MSRV CI
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4671:
URL: https://github.com/apache/arrow-rs/pull/4671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4671: Fix MSRV CI
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4671:
URL: https://github.com/apache/arrow-rs/pull/4671#discussion_r1288866927
##########
.github/workflows/rust.yml:
##########
@@ -121,6 +121,10 @@ jobs:
- name: Check arrow-flight
working-directory: arrow-flight
run: cargo msrv verify
+ - name: Downgrade object_store dependencies
+ working-directory: object_store
+ # Necessary because 1.30.0 updates MSRV to 1.63
+ run: cargo update -p tokio --precise 1.29.1
Review Comment:
Other options would be to:
* Add a maximum version constraint
* Check in a lockfile
But both of these have obvious drawbacks, this seemed relatively unintrusive. Hopefully at some point cargo will add MSRV aware resolution so these sort of shenanigans will be handled automatically - https://github.com/rust-lang/cargo/issues/9930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org