You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "treivize (via GitHub)" <gi...@apache.org> on 2024/03/05 14:40:33 UTC
[PR] [incubator-kie-issues-989] Add a null check on milestones attribute in ProcessDetails component [incubator-kie-kogito-apps]
treivize opened a new pull request, #2010:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2010
See issue: https://github.com/apache/incubator-kie-issues/issues/989
Building and running the data-index service and the management console based on master branch, it seems that milestones attribute can be now null instead of being an empty array as before.
I have the feeling that it is following this big refactor on the serialization of the process instance feed between the kogito runtime and the data-index service: https://github.com/apache/incubator-kie-kogito-apps/commit/ffc8500bbdfb979598392719d3b629a673ee5bdf
A simple optional chaining operator is resolving the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-989] Add a null check on milestones attribute in ProcessDetails component [incubator-kie-kogito-apps]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2010:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2010#issuecomment-1991996436
@treivize The ETA is ASAP :), it's an high-priority task. However, that task has a huge impact on our code base, so we don't have a precise ETA for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-989] Add a null check on milestones attribute in ProcessDetails component [incubator-kie-kogito-apps]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer closed pull request #2010: [incubator-kie-issues-989] Add a null check on milestones attribute in ProcessDetails component
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-989] Add a null check on milestones attribute in ProcessDetails component [incubator-kie-kogito-apps]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2010:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2010#issuecomment-2040043566
@treivize The above PR has been merged. Please check and close the kie-issues ticket if the fix is fine. Closing this. Thank you again for your effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-989] Add a null check on milestones attribute in ProcessDetails component [incubator-kie-kogito-apps]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2010:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2010#issuecomment-1982988002
@treivize Thank you for providing this patch and for following our fixing process (opening a ticket and its related PR), we appreciate it a lot!
However, the code that impacts your change will be soon moved into another repository (https://github.com/apache/incubator-kie-tools/pull/2180). Moreover, that PR [already contains a null guard ](https://github.com/apache/incubator-kie-tools/pull/2180/files#diff-c338a47660db694f8c5a8e53c2a0863ade7dba30d5e61d0a9e10d6399e4d3567R311)
After the merge of that PR, the involved code will be removed from this` kogito-apps` repo.
With these premises, I guess doesn't make sense to merge your PR, despite your change being correct.
In any case, I invite you to double-check if the bug you spotted still occurs after the PR merge, if that is the case please feel free to open a new PR in the `kie-tools` repo.
Thank you again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-989] Add a null check on milestones attribute in ProcessDetails component [incubator-kie-kogito-apps]
Posted by "treivize (via GitHub)" <gi...@apache.org>.
treivize commented on PR #2010:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2010#issuecomment-1985959367
@yesamer, waiting for the PR to be merged eagerly to test from there. Any idea when it will be completed?
Feel free to close this PR anytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org