[kudu-CR] KUDU-966. Construct and cache the master registration PB at startup

["Todd Lipcon (Code Review)" <ge...@ip-10-146-233-104.ec2.internal>]

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2053

to review the following change.

Change subject: KUDU-966. Construct and cache the master registration PB at startup
......................................................................

KUDU-966. Construct and cache the master registration PB at startup

On some clusters, calls to determine the FQDN can run very slowly if the DNS is
not set up properly. This can cause GetMasterRegistration RPCs to take several
seconds, and cause the master to basically fall over.

This moves the call to construct the registration protobuf into the startup
sequence, so that the RPC can be satisfied by a simple copy from the
cached value.

No new tests since this is a performance improvement which is only visible
on machines with broken DNS.

Change-Id: I79bac224d905cad579a6f4fa6552b8ea17af6b4a
---
M src/kudu/master/master.cc
M src/kudu/master/master.h
2 files changed, 34 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/2053/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79bac224d905cad579a6f4fa6552b8ea17af6b4a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans