[GitHub] [spark] sarutak edited a comment on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test

[GitBox <gi...@apache.org>]

sarutak edited a comment on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946719580


   @AngersZhuuuu What is the worth of just removing `server.initialize()` from the UTs in a single PR?
   If we will have less benefit, is it better not to bother to remove them now ?
   When we modify those files, we can remove them together.
   If you will add new tests to `HistoryServerSuite` in #34326, why don't you remove them in that PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org