[jira] [Commented] (OFBIZ-7297) Migrate promotext.properties to UiLabels

["Mridul Pathak (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362276#comment-15362276 ] 

Mridul Pathak commented on OFBIZ-7297:
--------------------------------------

Thanks Suraj for your contribution. Your patch in trunk r1751424 and r1751427.

I am not closing this ticket as we still need to migrate promotext_zh.properties and promotext_zh_TW.properties.


> Migrate promotext.properties to UiLabels
> ----------------------------------------
>
>                 Key: OFBIZ-7297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Minor
>         Attachments: OFBIZ-7297.patch
>
>
> promotext.properties file is used only in ProductPromoWorker.makeAutoDescription() method and was implemented way back when UI Labels were managed in *.properties files. It should be moved to UiLabels file because all the properties defined in the file are text descriptions and not system configurations, which makes them a candidate of internationalization.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)