[GitHub] pierrekilly commented on a change in pull request #1160: Add support for Bcrypt password hashing

[GitBox <gi...@apache.org>]

pierrekilly commented on a change in pull request #1160: Add support for Bcrypt password hashing
URL: https://github.com/apache/couchdb/pull/1160#discussion_r167856980
 
 

 ##########
 File path: src/couch/src/couch_users_db.erl
 ##########
 @@ -75,7 +76,7 @@ save_doc(#doc{body={Body}} = Doc) ->
         Body3 = proplists:delete(?PASSWORD, Body2),
         Doc#doc{body={Body3}};
     {ClearPassword, "pbkdf2"} ->
-        Iterations = list_to_integer(config:get("couch_httpd_auth", "iterations", "1000")),
+        Iterations = list_to_integer(config:get("couch_httpd_auth", "iterations", "10000")),
 
 Review comment:
   That's right. I simply noticed that [the default value in the `authenticate` function in couch_httpd_auth.erl is 10000](https://github.com/apache/couchdb/blob/master/src/couch/src/couch_httpd_auth.erl#L401) so I thought this was a misspelling.
   Wasn't aware of `rel/overlay/etc/default.ini` but I guess I should just roll back this change, should I?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services