You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/04/10 20:16:46 UTC
Review Request 33089: RU Hacks and Technical Debt - Unit Test for
(pre|post)_rolling_restart across several services. HDFS unit tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33089/
-----------------------------------------------------------
Review request for Ambari and Alejandro Fernandez.
Bugs: AMBARI-10444
https://issues.apache.org/jira/browse/AMBARI-10444
Repository: ambari
Description
-------
Missing HDFS unit test coverage for RU
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java e4b26b1
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py 60c8eb8
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 54ca083
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py 5da0f04
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 21cefae
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 308476e
Diff: https://reviews.apache.org/r/33089/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [1.623s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.776s]
[INFO] Ambari Server ..................................... SUCCESS [36.903s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39.905s
[INFO] Finished at: Fri Apr 10 21:16:23 EEST 2015
[INFO] Final Memory: 49M/433M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 33089: RU Hacks and Technical Debt - Unit Test for
(pre|post)_rolling_restart across several services. HDFS unit tests
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33089/#review79732
-----------------------------------------------------------
Ship it!
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py
<https://reviews.apache.org/r/33089/#comment129265>
we should use pythonic_function_names. If not too many script use this, we should change it, otherwise, leave as is.
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py
<https://reviews.apache.org/r/33089/#comment129266>
we should store this value as a variable since it's used below in the call to hdp-select.
Same for the other python unit test files.
- Alejandro Fernandez
On April 10, 2015, 6:16 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33089/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 6:16 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10444
> https://issues.apache.org/jira/browse/AMBARI-10444
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Missing HDFS unit test coverage for RU
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java e4b26b1
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py 60c8eb8
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 54ca083
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py 5da0f04
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 21cefae
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 308476e
>
> Diff: https://reviews.apache.org/r/33089/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [1.623s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.776s]
> [INFO] Ambari Server ..................................... SUCCESS [36.903s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39.905s
> [INFO] Finished at: Fri Apr 10 21:16:23 EEST 2015
> [INFO] Final Memory: 49M/433M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 33089: RU Hacks and Technical Debt - Unit Test for
(pre|post)_rolling_restart across several services. HDFS unit tests
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33089/#review79739
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 10, 2015, 6:35 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33089/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 6:35 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10444
> https://issues.apache.org/jira/browse/AMBARI-10444
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Missing HDFS unit test coverage for RU
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java e4b26b1
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py 60c8eb8
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py d2c340b
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py b6f4821
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 54ca083
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py 5da0f04
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 21cefae
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 308476e
> ambari-server/src/test/python/stacks/2.0.6/SQOOP/test_sqoop.py b65ada9
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py dc2d861
>
> Diff: https://reviews.apache.org/r/33089/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [1.623s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.776s]
> [INFO] Ambari Server ..................................... SUCCESS [36.903s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39.905s
> [INFO] Finished at: Fri Apr 10 21:16:23 EEST 2015
> [INFO] Final Memory: 49M/433M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 33089: RU Hacks and Technical Debt - Unit Test for
(pre|post)_rolling_restart across several services. HDFS unit tests
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33089/
-----------------------------------------------------------
(Updated April 10, 2015, 6:35 p.m.)
Review request for Ambari and Alejandro Fernandez.
Changes
-------
Fixed comments
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.133s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.088s]
[INFO] Ambari Server ..................................... SUCCESS [50.985s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 56.079s
[INFO] Finished at: Fri Apr 10 21:34:39 EEST 2015
[INFO] Final Memory: 49M/410M
[INFO] ------------------------------------------------------------------------
Bugs: AMBARI-10444
https://issues.apache.org/jira/browse/AMBARI-10444
Repository: ambari
Description
-------
Missing HDFS unit test coverage for RU
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java e4b26b1
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py 60c8eb8
ambari-server/src/test/python/custom_actions/TestInstallPackages.py d2c340b
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py b6f4821
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 54ca083
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py 5da0f04
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 21cefae
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 308476e
ambari-server/src/test/python/stacks/2.0.6/SQOOP/test_sqoop.py b65ada9
ambari-server/src/test/python/stacks/utils/RMFTestCase.py dc2d861
Diff: https://reviews.apache.org/r/33089/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [1.623s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.776s]
[INFO] Ambari Server ..................................... SUCCESS [36.903s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39.905s
[INFO] Finished at: Fri Apr 10 21:16:23 EEST 2015
[INFO] Final Memory: 49M/433M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko