You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/11/18 05:25:24 UTC

[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3653: Bring back deleteRange for RocksDB to improve location delete performance

hangc0276 opened a new pull request, #3653:
URL: https://github.com/apache/bookkeeper/pull/3653

   ### Motivation
   The entry log location index deletion is deleted in batches one by one currently, and it will have low performance. Refer to: https://github.com/apache/bookkeeper/pull/3646
   
   Matteo has introduced deleteRange API a few years ago, but rollback due to RocksDB delete ranges bug. https://github.com/apache/bookkeeper/pull/1620.  The RocksDB bug has been addressed since 5.18.0 https://github.com/facebook/rocksdb/blob/main/HISTORY.md#5180-2018-11-30. We can bring the `deleteRange` API back to improve the entry log location deletion performance.
   
   ### Changes
   Bring `deleteRange` API back for entry log location deletion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] hangc0276 merged pull request #3653: Bring back deleteRange for RocksDB to improve location delete performance

Posted by GitBox <gi...@apache.org>.
hangc0276 merged PR #3653:
URL: https://github.com/apache/bookkeeper/pull/3653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] hangc0276 commented on pull request #3653: Bring back deleteRange for RocksDB to improve location delete performance

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3653:
URL: https://github.com/apache/bookkeeper/pull/3653#issuecomment-1319680822

   > Great !
   > 
   > Looking forward to see this in 4.16.0, and probably we can port it to 4.15 branch
   
   @eolivelli Yes, I will cherry-pick it to branch-4.14 and branch-4.15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org