You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Jamie Goodyear (JIRA)" <ji...@apache.org> on 2008/02/02 18:50:37 UTC

[jira] Updated: (SM-1130) FtpPoller should offer configurable targetOperation

     [ https://issues.apache.org/activemq/browse/SM-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jamie Goodyear updated SM-1130:
-------------------------------

    Attachment: SM1130_patch.txt


Attached file contains svn diff for the supplied update provided by Philippe Pinheiro (similar to issue reported by Oliver Brusberg in SM-1115). 

Tested on Mac OSX 10.5.2
Java: 1.5.0_13

> FtpPoller should offer configurable targetOperation
> ---------------------------------------------------
>
>                 Key: SM-1130
>                 URL: https://issues.apache.org/activemq/browse/SM-1130
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-ftp
>    Affects Versions: 3.1.2
>            Reporter: Philippe Pinheiro
>         Attachments: SM1130_patch.txt
>
>
> Same issue as for FilePoller :  SM-1115
> FtpPoller currently does not use a target operation when sending a message to a target service. The operation must be set, for example, when sending a file to a Ode SU. If not set, Ode throws sort of NPE complaining operation is not set.
> FtpPoller should offer a targetOperation property configurable via XBeans.
> This can be achieved by adding a targetOperation property 
> ...
> private QName targetOperation = null;
> ...
> public QName getTargetOperation() { return targetOperation; }
> public void setTargetOperation(QName targetOperation) { this.targetOperation = targetOperation; }
> ...
> protected void processFile(File aFile) throws Exception { ... exchange.setInMessage(message); if (getTargetOperation() != null) exchange.setOperation(getTargetOperation()); // <--- NEW marshaler.readMessage(exchange, message, in, name); ... }
> Then, the SU may be configured properly as follows:
> <f:poller
> service="proj:inbox"
> endpoint="inbox"
> targetService="process:receive"
> targetOperation="process:receive"
> ...
> </f:poller>
> In case the attribute is not set in the xbean.xml, the current behaviour is not changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (SM-1130) FtpPoller should offer configurable targetOperation

Posted by Bruce Snyder <br...@gmail.com>.
On Feb 4, 2008 8:40 AM, jgoodyear <ja...@gmail.com> wrote:
>
>
>  Hi All,
>
>  Could I have someone provide a quick review of the two issues highlighted
> below?
>  (SM-1130 and SM-1115).

I'll take a look at them now, Jamie.

Bruce
-- 
perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
);'

Apache ActiveMQ - http://activemq.org/
Apache Camel - http://activemq.org/camel/
Apache ServiceMix - http://servicemix.org/
Apache Geronimo - http://geronimo.apache.org/

Blog: http://bruceblog.org/

Re: [jira] Updated: (SM-1130) FtpPoller should offer configurable targetOperation

Posted by jgoodyear <ja...@gmail.com>.

 Hi All,

 Could I have someone provide a quick review of the two issues highlighted
below?
 (SM-1130 and SM-1115).

 Thanks,
 Jamie G.



JIRA jira@apache.org wrote:
> 
> 
>      [
> https://issues.apache.org/activemq/browse/SM-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> 
> Jamie Goodyear updated SM-1130:
> -------------------------------
> 
>     Attachment: SM1130_patch.txt
> 
> 
> Attached file contains svn diff for the supplied update provided by
> Philippe Pinheiro (similar to issue reported by Oliver Brusberg in
> SM-1115). 
> 
> Tested on Mac OSX 10.5.2
> Java: 1.5.0_13
> 
>> FtpPoller should offer configurable targetOperation
>> ---------------------------------------------------
>>
>>                 Key: SM-1130
>>                 URL: https://issues.apache.org/activemq/browse/SM-1130
>>             Project: ServiceMix
>>          Issue Type: Improvement
>>          Components: servicemix-ftp
>>    Affects Versions: 3.1.2
>>            Reporter: Philippe Pinheiro
>>         Attachments: SM1130_patch.txt
>>
>>
>> Same issue as for FilePoller :  SM-1115
>> FtpPoller currently does not use a target operation when sending a
>> message to a target service. The operation must be set, for example, when
>> sending a file to a Ode SU. If not set, Ode throws sort of NPE
>> complaining operation is not set.
>> FtpPoller should offer a targetOperation property configurable via
>> XBeans.
>> This can be achieved by adding a targetOperation property 
>> ...
>> private QName targetOperation = null;
>> ...
>> public QName getTargetOperation() { return targetOperation; }
>> public void setTargetOperation(QName targetOperation) {
>> this.targetOperation = targetOperation; }
>> ...
>> protected void processFile(File aFile) throws Exception { ...
>> exchange.setInMessage(message); if (getTargetOperation() != null)
>> exchange.setOperation(getTargetOperation()); // <--- NEW
>> marshaler.readMessage(exchange, message, in, name); ... }
>> Then, the SU may be configured properly as follows:
>> <f:poller
>> service="proj:inbox"
>> endpoint="inbox"
>> targetService="process:receive"
>> targetOperation="process:receive"
>> ...
>> </f:poller>
>> In case the attribute is not set in the xbean.xml, the current behaviour
>> is not changed.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
> 
> 
> 

-- 
View this message in context: http://www.nabble.com/-jira--Updated%3A-%28SM-1130%29-FtpPoller-should-offer-configurable-targetOperation-tp15245316s12049p15269006.html
Sent from the ServiceMix - Dev mailing list archive at Nabble.com.