You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Viet Hung Nguyen (JIRA)" <ji...@apache.org> on 2007/10/20 19:39:50 UTC
[jira] Created: (GERONIMO-3541) monitoring plugin: collecting agent
needs to use a database to store the snapshots instead of xml
monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
-------------------------------------------------------------------------------------------------
Key: GERONIMO-3541
URL: https://issues.apache.org/jira/browse/GERONIMO-3541
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: monitoring
Affects Versions: 2.1
Environment: windows
Reporter: Viet Hung Nguyen
The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3541) monitoring plugin: collecting
agent needs to use a database to store the snapshots instead of xml
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537191 ]
Anita Kulshreshtha commented on GERONIMO-3541:
----------------------------------------------
Joe, thanks for taking care of the patch.
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Joe Bohn
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3541) monitoring plugin: collecting
agent needs to use a database to store the snapshots instead of xml
Posted by "Erik B. Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536881 ]
Erik B. Craig commented on GERONIMO-3541:
-----------------------------------------
Viet - I might suggest a different approach to saving the information in the database. Currently you are using 1 row for every mbean/data element combination... with a default configuration on tomcat that is 46 rows - or roughly 8KB of data per snapshot with how your table is configured... with a default configuration snapshot interval of 5 minutes, that will result in significant memory usage rather quickly.
I might suggest an alternative approach, breaking apart the mbeans into a separate table so that the raw text of the mbean path isn't re-saved thousands of times, as it it particularly redundant. I would also suggest breaking away the data element names into this table, perhaps in the same row as the mbean names delimited by a comma or a colon... I have a few other ideas which will result in significantly less storage and memory usage over time that we can discuss in more detail if you wish.
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3541) monitoring plugin: collecting agent
needs to use a database to store the snapshots instead of xml
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3541:
---------------------------------------
Attachment: (was: geronimo-3541.patch)
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-3541) monitoring plugin: collecting
agent needs to use a database to store the snapshots instead of xml
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen resolved GERONIMO-3541.
----------------------------------------
Resolution: Fixed
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Joe Bohn
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3541) monitoring plugin: collecting agent
needs to use a database to store the snapshots instead of xml
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3541:
---------------------------------------
Attachment: geronimo-3541.patch
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3541) monitoring plugin: collecting agent
needs to use a database to store the snapshots instead of xml
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3541:
---------------------------------------
Attachment: (was: geronimo-3541.patch)
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3541) monitoring plugin: collecting agent
needs to use a database to store the snapshots instead of xml
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3541:
---------------------------------------
Attachment: (was: geronimo-3541.patch)
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3541) monitoring plugin: collecting agent
needs to use a database to store the snapshots instead of xml
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3541:
---------------------------------------
Attachment: geronimo-3541.patch
This patch differs from the previous patch. I changed the data type of snapshot_time (the number of seconds since 1970) to be of type BIGINT in the db instead of a String.
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3541) monitoring plugin: collecting agent
needs to use a database to store the snapshots instead of xml
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3541:
---------------------------------------
Attachment: geronimo-3541.patch
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3541) monitoring plugin: collecting
agent needs to use a database to store the snapshots instead of xml
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537152 ]
Joe Bohn commented on GERONIMO-3541:
------------------------------------
Anita, I hope you don't mind me checking this patch in. Viet had some other changes that were waiting on this patch so I am just helping to keep him moving along. I figured that since was still in sandbox things can easily change if you wanted to see more changes in the implementation. Thanks for the patch Viet!
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Joe Bohn
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-3541) monitoring plugin: collecting
agent needs to use a database to store the snapshots instead of xml
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bohn reassigned GERONIMO-3541:
----------------------------------
Assignee: Joe Bohn
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Joe Bohn
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3541) monitoring plugin: collecting agent
needs to use a database to store the snapshots instead of xml
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3541:
---------------------------------------
Attachment: geronimo-3541.patch
I have changed the db structure to be as the following:
Statistics
-mbeanid (F.K. refs MBeans.id)
-snapshotid (F.K. refs Snapshots.id)
-statsValue
-statsName
MBeans
-id (P.K.)
-mbeanName
Snapshots
-id (P.K.)
-snapshot_time
-snapshot_date
Erik, I do not think that putting statistics names in a CSV list in a db is a good practice. And in this case, I will not be able to save a statsValue for each statsName if I did that. There would not be a way of mapping it. However, I have broken up the table into multiple pieces as we have discussed before.
If someone could take a look at this, it will be great, because it is a significant part that needs to be established before we can move on to other things.
> monitoring plugin: collecting agent needs to use a database to store the snapshots instead of xml
> -------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3541
> URL: https://issues.apache.org/jira/browse/GERONIMO-3541
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3541.patch
>
>
> The DB needs to be populated with snapshot statistics. Also, the functions used to query snapshots needs to be migrated from reading from XML files to a DB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.