You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "huonw (via GitHub)" <gi...@apache.org> on 2023/09/23 03:52:48 UTC
[GitHub] [incubator-opendal] huonw opened a new pull request, #3163: Include starting offset for GHAC upload Content-Range
huonw opened a new pull request, #3163:
URL: https://github.com/apache/incubator-opendal/pull/3163
This adjusts the GitHub Action Cache service to handle multi-part uploads correctly: each upload part needs to specify exactly the range it is for, e.g. to upload an 11 byte file with parts <= 8 bytes, the two requests should set:
1. `Content-Range: bytes 0-8/*` (first 8 bytes)
2. `Content-Range: bytes 9-10/*` (final 3 bytes)
Previously, the second request would be `Content-Range: 0-2/*`. This would leave the file not-fully written, and GitHub would reject it with an error.
Fixes #3162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] huonw commented on pull request #3163: Include starting offset for GHAC upload Content-Range
Posted by "huonw (via GitHub)" <gi...@apache.org>.
huonw commented on PR #3163:
URL: https://github.com/apache/incubator-opendal/pull/3163#issuecomment-1732201456
There doesn't appear to be automatic tests for GHAC? Let me know if I've missed them.
I've tested this in GHA:
- Code: https://github.com/huonw/pants-cache-github-actions-poc/blob/5b2962bb6dc686820e8e246488d2e4df1b36bedf/src/main.rs (same as reproducer from #3162 just with an extra `println!` + `read` at the end)
- https://github.com/huonw/pants-cache-github-actions-poc/actions/runs/6281454756/job/17059844654#step:4:315 successful run ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #3163: feat: Include starting offset for GHAC upload Content-Range
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3163:
URL: https://github.com/apache/incubator-opendal/pull/3163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3163: feat: Include starting offset for GHAC upload Content-Range
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3163:
URL: https://github.com/apache/incubator-opendal/pull/3163#issuecomment-1732207742
> There doesn't appear to be automatic tests for GHAC? Let me know if I've missed them.
GHAC requires github secrets which can't be fetched from a forked repository. This is a github issue. You have already done the great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org