You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/03/22 00:25:40 UTC
Review Request 45132: GEODE-1115 membership-port-range is not being
established properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45132/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
Bugs: GEODE-1115
https://issues.apache.org/jira/browse/GEODE-1115
Repository: geode
Description
-------
added 1 more port to the jgroups port_range and renamed the place-holder string in jgroups configuration files
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 9476debc727ce389aa699aade32864905d9825c2
geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-config.xml 841336436c288f3cac4f8a5e43320fa158cd3662
geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-mcast.xml ff5a8e132304f8b247867df17af9ddf5acda9b4a
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java f34fd7ecd94d75bcbeed71c9049a4688a56abff7
Diff: https://reviews.apache.org/r/45132/diff/
Testing
-------
added unit test ensuring jgroups is properly configured
Thanks,
Bruce Schuchardt
Re: Review Request 45132: GEODE-1115 membership-port-range is not
being established properly
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On March 21, 2016, 11:35 p.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java, line 243
> > <https://reviews.apache.org/r/45132/diff/1/?file=1309587#file1309587line243>
> >
> > I thought range is inclusive. i mean, if it is defined like (3-5 ), then jgroup will consider port 3,4,5.
> >
> > So I think we don't need (ports[1]-ports[0]+1)) here..
> >
> > I am coming from here "http://www.jgroups.org/manual/html/user-advanced.html"
You're quite right - I'll revert that change Hitesh
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45132/#review124682
-----------------------------------------------------------
On March 21, 2016, 11:25 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45132/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:25 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1115
> https://issues.apache.org/jira/browse/GEODE-1115
>
>
> Repository: geode
>
>
> Description
> -------
>
> added 1 more port to the jgroups port_range and renamed the place-holder string in jgroups configuration files
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 9476debc727ce389aa699aade32864905d9825c2
> geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-config.xml 841336436c288f3cac4f8a5e43320fa158cd3662
> geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-mcast.xml ff5a8e132304f8b247867df17af9ddf5acda9b4a
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java f34fd7ecd94d75bcbeed71c9049a4688a56abff7
>
> Diff: https://reviews.apache.org/r/45132/diff/
>
>
> Testing
> -------
>
> added unit test ensuring jgroups is properly configured
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 45132: GEODE-1115 membership-port-range is not
being established properly
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45132/#review124682
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java (line 243)
<https://reviews.apache.org/r/45132/#comment187310>
I thought range is inclusive. i mean, if it is defined like (3-5 ), then jgroup will consider port 3,4,5.
So I think we don't need (ports[1]-ports[0]+1)) here..
I am coming from here "http://www.jgroups.org/manual/html/user-advanced.html"
- Hitesh Khamesra
On March 21, 2016, 11:25 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45132/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:25 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1115
> https://issues.apache.org/jira/browse/GEODE-1115
>
>
> Repository: geode
>
>
> Description
> -------
>
> added 1 more port to the jgroups port_range and renamed the place-holder string in jgroups configuration files
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 9476debc727ce389aa699aade32864905d9825c2
> geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-config.xml 841336436c288f3cac4f8a5e43320fa158cd3662
> geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-mcast.xml ff5a8e132304f8b247867df17af9ddf5acda9b4a
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java f34fd7ecd94d75bcbeed71c9049a4688a56abff7
>
> Diff: https://reviews.apache.org/r/45132/diff/
>
>
> Testing
> -------
>
> added unit test ensuring jgroups is properly configured
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 45132: GEODE-1115 membership-port-range is not
being established properly
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On March 22, 2016, midnight, Jianxia Chen wrote:
> > geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-config.xml, line 23
> > <https://reviews.apache.org/r/45132/diff/1/?file=1309588#file1309588line23>
> >
> > How about just call it MEMBERSHIP_PORT_RANGE?
okay. SIZE is incorrect anyway given what Hitesh pointed out
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45132/#review124689
-----------------------------------------------------------
On March 21, 2016, 11:25 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45132/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:25 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1115
> https://issues.apache.org/jira/browse/GEODE-1115
>
>
> Repository: geode
>
>
> Description
> -------
>
> added 1 more port to the jgroups port_range and renamed the place-holder string in jgroups configuration files
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 9476debc727ce389aa699aade32864905d9825c2
> geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-config.xml 841336436c288f3cac4f8a5e43320fa158cd3662
> geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-mcast.xml ff5a8e132304f8b247867df17af9ddf5acda9b4a
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java f34fd7ecd94d75bcbeed71c9049a4688a56abff7
>
> Diff: https://reviews.apache.org/r/45132/diff/
>
>
> Testing
> -------
>
> added unit test ensuring jgroups is properly configured
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 45132: GEODE-1115 membership-port-range is not
being established properly
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45132/#review124689
-----------------------------------------------------------
geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-config.xml (line 23)
<https://reviews.apache.org/r/45132/#comment187313>
How about just call it MEMBERSHIP_PORT_RANGE?
- Jianxia Chen
On March 21, 2016, 11:25 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45132/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:25 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1115
> https://issues.apache.org/jira/browse/GEODE-1115
>
>
> Repository: geode
>
>
> Description
> -------
>
> added 1 more port to the jgroups port_range and renamed the place-holder string in jgroups configuration files
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 9476debc727ce389aa699aade32864905d9825c2
> geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-config.xml 841336436c288f3cac4f8a5e43320fa158cd3662
> geode-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-mcast.xml ff5a8e132304f8b247867df17af9ddf5acda9b4a
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java f34fd7ecd94d75bcbeed71c9049a4688a56abff7
>
> Diff: https://reviews.apache.org/r/45132/diff/
>
>
> Testing
> -------
>
> added unit test ensuring jgroups is properly configured
>
>
> Thanks,
>
> Bruce Schuchardt
>
>