You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/10 10:45:26 UTC

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #199: [FLINK-27551] Update status manually instead of relying on updatecontrol

morhidi commented on code in PR #199:
URL: https://github.com/apache/flink-kubernetes-operator/pull/199#discussion_r869090012


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java:
##########
@@ -86,26 +92,29 @@ public FlinkDeploymentController(
     @Override
     public DeleteControl cleanup(FlinkDeployment flinkApp, Context context) {
         LOG.info("Deleting FlinkDeployment");
+        OperatorUtils.updateStatusFromCache(flinkApp, statusCache);

Review Comment:
   @gyfora This means to me we never give a chance to update the status outside the operator, correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org