You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "EMsnap (via GitHub)" <gi...@apache.org> on 2023/04/24 06:44:21 UTC
[GitHub] [inlong] EMsnap commented on a diff in pull request #7905: [INLONG-7903][Sort] Kafka sink supports fixed partition strategy
EMsnap commented on code in PR #7905:
URL: https://github.com/apache/inlong/pull/7905#discussion_r1174848538
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -187,7 +190,18 @@ public final class Constants {
.noDefaultValue()
.withDescription(
"The format of multiple sink, it represents the real format of the raw binary data");
-
+ public static final ConfigOption<String> PATTERN_PARTITION_MAP =
+ ConfigOptions.key("pattern.partition.map")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "Pattern rules and partition maps");
Review Comment:
detailed descrption like a example for the parameter may be good for reading
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -187,7 +190,18 @@ public final class Constants {
.noDefaultValue()
.withDescription(
"The format of multiple sink, it represents the real format of the raw binary data");
-
+ public static final ConfigOption<String> PATTERN_PARTITION_MAP =
+ ConfigOptions.key("pattern.partition.map")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "Pattern rules and partition maps");
+ public static final ConfigOption<Map<String, String>> DATASOURCE_PARTITION_MAP =
+ ConfigOptions.key("datasource.partition.map")
+ .mapType()
+ .noDefaultValue()
+ .withDescription(
+ "Datasource and partition maps");
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org