You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by "Nirmal Fernando (JIRA)" <ji...@apache.org> on 2014/10/08 04:29:33 UTC

[jira] [Commented] (STRATOS-876) [Sonar Findings] [Critical] A catch statement should never catch throwable

    [ https://issues.apache.org/jira/browse/STRATOS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162962#comment-14162962 ] 

Nirmal Fernando commented on STRATOS-876:
-----------------------------------------

Hi Imesh,

We already have a Jira to track Sonar reported critical issues [1]. Should
we add these as sub tasks of that?

[1] https://issues.apache.org/jira/browse/STRATOS-813

On Wed, Oct 8, 2014 at 7:51 AM, Imesh Gunaratne (JIRA) <ji...@apache.org>




-- 
Best Regards,
Nirmal

Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.

Blog: http://nirmalfdo.blogspot.com/


> [Sonar Findings] [Critical] A catch statement should never catch throwable
> --------------------------------------------------------------------------
>
>                 Key: STRATOS-876
>                 URL: https://issues.apache.org/jira/browse/STRATOS-876
>             Project: Stratos
>          Issue Type: Improvement
>            Reporter: Imesh Gunaratne
>
>  A catch statement should never catch throwable since it includes errors.
> https://analysis.apache.org/drilldown/issues/162219?severity=CRITICAL



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Commented] (STRATOS-876) [Sonar Findings] [Critical] A catch statement should never catch throwable

Posted by Nirmal Fernando <ni...@gmail.com>.
Great! Thanks .

On Wed, Oct 8, 2014 at 8:33 AM, Imesh Gunaratne <im...@apache.org> wrote:

> Great! Will group all issues together and fix.
>
> Thanks
>
> On Wed, Oct 8, 2014 at 8:17 AM, Nirmal Fernando <ni...@gmail.com>
> wrote:
>
>> Yes, I've mentioned them in the commits not in the Jira.
>>
>> On Wed, Oct 8, 2014 at 8:15 AM, Imesh Gunaratne <im...@apache.org> wrote:
>>
>>> Yes we could do that. I can see you have fixed some of the problems in
>>> this issue, if we could mention the titles of the findings in this, I think
>>> it would be great.
>>>
>>> On Wed, Oct 8, 2014 at 7:59 AM, Nirmal Fernando (JIRA) <ji...@apache.org>
>>> wrote:
>>>
>>>>
>>>>     [
>>>> https://issues.apache.org/jira/browse/STRATOS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162962#comment-14162962
>>>> ]
>>>>
>>>> Nirmal Fernando commented on STRATOS-876:
>>>> -----------------------------------------
>>>>
>>>> Hi Imesh,
>>>>
>>>> We already have a Jira to track Sonar reported critical issues [1].
>>>> Should
>>>> we add these as sub tasks of that?
>>>>
>>>> [1] https://issues.apache.org/jira/browse/STRATOS-813
>>>>
>>>> On Wed, Oct 8, 2014 at 7:51 AM, Imesh Gunaratne (JIRA) <jira@apache.org
>>>> >
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>> Nirmal
>>>>
>>>> Nirmal Fernando.
>>>> PPMC Member & Committer of Apache Stratos,
>>>> Senior Software Engineer, WSO2 Inc.
>>>>
>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>
>>>>
>>>> > [Sonar Findings] [Critical] A catch statement should never catch
>>>> throwable
>>>> >
>>>> --------------------------------------------------------------------------
>>>> >
>>>> >                 Key: STRATOS-876
>>>> >                 URL:
>>>> https://issues.apache.org/jira/browse/STRATOS-876
>>>> >             Project: Stratos
>>>> >          Issue Type: Improvement
>>>> >            Reporter: Imesh Gunaratne
>>>> >
>>>> >  A catch statement should never catch throwable since it includes
>>>> errors.
>>>> > https://analysis.apache.org/drilldown/issues/162219?severity=CRITICAL
>>>>
>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.3.4#6332)
>>>>
>>>
>>>
>>>
>>> --
>>> Imesh Gunaratne
>>>
>>> Technical Lead, WSO2
>>> Committer & PMC Member, Apache Stratos
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Imesh Gunaratne
>
> Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>



-- 
Best Regards,
Nirmal

Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.

Blog: http://nirmalfdo.blogspot.com/

Re: [jira] [Commented] (STRATOS-876) [Sonar Findings] [Critical] A catch statement should never catch throwable

Posted by Imesh Gunaratne <im...@apache.org>.
Great! Will group all issues together and fix.

Thanks

On Wed, Oct 8, 2014 at 8:17 AM, Nirmal Fernando <ni...@gmail.com>
wrote:

> Yes, I've mentioned them in the commits not in the Jira.
>
> On Wed, Oct 8, 2014 at 8:15 AM, Imesh Gunaratne <im...@apache.org> wrote:
>
>> Yes we could do that. I can see you have fixed some of the problems in
>> this issue, if we could mention the titles of the findings in this, I think
>> it would be great.
>>
>> On Wed, Oct 8, 2014 at 7:59 AM, Nirmal Fernando (JIRA) <ji...@apache.org>
>> wrote:
>>
>>>
>>>     [
>>> https://issues.apache.org/jira/browse/STRATOS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162962#comment-14162962
>>> ]
>>>
>>> Nirmal Fernando commented on STRATOS-876:
>>> -----------------------------------------
>>>
>>> Hi Imesh,
>>>
>>> We already have a Jira to track Sonar reported critical issues [1].
>>> Should
>>> we add these as sub tasks of that?
>>>
>>> [1] https://issues.apache.org/jira/browse/STRATOS-813
>>>
>>> On Wed, Oct 8, 2014 at 7:51 AM, Imesh Gunaratne (JIRA) <ji...@apache.org>
>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>> Nirmal
>>>
>>> Nirmal Fernando.
>>> PPMC Member & Committer of Apache Stratos,
>>> Senior Software Engineer, WSO2 Inc.
>>>
>>> Blog: http://nirmalfdo.blogspot.com/
>>>
>>>
>>> > [Sonar Findings] [Critical] A catch statement should never catch
>>> throwable
>>> >
>>> --------------------------------------------------------------------------
>>> >
>>> >                 Key: STRATOS-876
>>> >                 URL: https://issues.apache.org/jira/browse/STRATOS-876
>>> >             Project: Stratos
>>> >          Issue Type: Improvement
>>> >            Reporter: Imesh Gunaratne
>>> >
>>> >  A catch statement should never catch throwable since it includes
>>> errors.
>>> > https://analysis.apache.org/drilldown/issues/162219?severity=CRITICAL
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>>
>>
>>
>>
>> --
>> Imesh Gunaratne
>>
>> Technical Lead, WSO2
>> Committer & PMC Member, Apache Stratos
>>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>



-- 
Imesh Gunaratne

Technical Lead, WSO2
Committer & PMC Member, Apache Stratos

Re: [jira] [Commented] (STRATOS-876) [Sonar Findings] [Critical] A catch statement should never catch throwable

Posted by Nirmal Fernando <ni...@gmail.com>.
Yes, I've mentioned them in the commits not in the Jira.

On Wed, Oct 8, 2014 at 8:15 AM, Imesh Gunaratne <im...@apache.org> wrote:

> Yes we could do that. I can see you have fixed some of the problems in
> this issue, if we could mention the titles of the findings in this, I think
> it would be great.
>
> On Wed, Oct 8, 2014 at 7:59 AM, Nirmal Fernando (JIRA) <ji...@apache.org>
> wrote:
>
>>
>>     [
>> https://issues.apache.org/jira/browse/STRATOS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162962#comment-14162962
>> ]
>>
>> Nirmal Fernando commented on STRATOS-876:
>> -----------------------------------------
>>
>> Hi Imesh,
>>
>> We already have a Jira to track Sonar reported critical issues [1]. Should
>> we add these as sub tasks of that?
>>
>> [1] https://issues.apache.org/jira/browse/STRATOS-813
>>
>> On Wed, Oct 8, 2014 at 7:51 AM, Imesh Gunaratne (JIRA) <ji...@apache.org>
>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>>
>> > [Sonar Findings] [Critical] A catch statement should never catch
>> throwable
>> >
>> --------------------------------------------------------------------------
>> >
>> >                 Key: STRATOS-876
>> >                 URL: https://issues.apache.org/jira/browse/STRATOS-876
>> >             Project: Stratos
>> >          Issue Type: Improvement
>> >            Reporter: Imesh Gunaratne
>> >
>> >  A catch statement should never catch throwable since it includes
>> errors.
>> > https://analysis.apache.org/drilldown/issues/162219?severity=CRITICAL
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
>
>
> --
> Imesh Gunaratne
>
> Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>



-- 
Best Regards,
Nirmal

Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.

Blog: http://nirmalfdo.blogspot.com/

Re: [jira] [Commented] (STRATOS-876) [Sonar Findings] [Critical] A catch statement should never catch throwable

Posted by Imesh Gunaratne <im...@apache.org>.
Yes we could do that. I can see you have fixed some of the problems in this
issue, if we could mention the titles of the findings in this, I think it
would be great.

On Wed, Oct 8, 2014 at 7:59 AM, Nirmal Fernando (JIRA) <ji...@apache.org>
wrote:

>
>     [
> https://issues.apache.org/jira/browse/STRATOS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162962#comment-14162962
> ]
>
> Nirmal Fernando commented on STRATOS-876:
> -----------------------------------------
>
> Hi Imesh,
>
> We already have a Jira to track Sonar reported critical issues [1]. Should
> we add these as sub tasks of that?
>
> [1] https://issues.apache.org/jira/browse/STRATOS-813
>
> On Wed, Oct 8, 2014 at 7:51 AM, Imesh Gunaratne (JIRA) <ji...@apache.org>
>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>
>
> > [Sonar Findings] [Critical] A catch statement should never catch
> throwable
> >
> --------------------------------------------------------------------------
> >
> >                 Key: STRATOS-876
> >                 URL: https://issues.apache.org/jira/browse/STRATOS-876
> >             Project: Stratos
> >          Issue Type: Improvement
> >            Reporter: Imesh Gunaratne
> >
> >  A catch statement should never catch throwable since it includes errors.
> > https://analysis.apache.org/drilldown/issues/162219?severity=CRITICAL
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>



-- 
Imesh Gunaratne

Technical Lead, WSO2
Committer & PMC Member, Apache Stratos