You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by wi...@apache.org on 2015/04/15 10:05:22 UTC
[22/53] [abbrv] git commit: updated refs/heads/reporter to 5c99784
findbugs: comparison of wrapper classes should use equals
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/d3a98ab0
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/d3a98ab0
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/d3a98ab0
Branch: refs/heads/reporter
Commit: d3a98ab0d00c787cb0fe2b53d532de65c873f4fb
Parents: 67719b1
Author: Daan Hoogland <dh...@schubergphilis.com>
Authored: Sun Apr 12 21:00:21 2015 +0200
Committer: Daan Hoogland <dh...@schubergphilis.com>
Committed: Sun Apr 12 21:00:21 2015 +0200
----------------------------------------------------------------------
.../src/com/cloud/network/element/BigSwitchBcfElement.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/d3a98ab0/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
----------------------------------------------------------------------
diff --git a/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java b/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
index 37391a6..1dbf62d 100644
--- a/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
+++ b/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
@@ -684,7 +684,7 @@ NetworkACLServiceProvider, FirewallServiceProvider, ResourceStateAdapter {
}
cidrList = r.getSourceCidrList();
if(cidrList != null){
- if(cidrList.size()>1 || r.getSourcePortEnd()!=r.getSourcePortStart()){
+ if (cidrList.size() > 1 || !r.getSourcePortEnd().equals(r.getSourcePortStart())) {
throw new ResourceUnavailableException("One CIDR and one port only please.",
Network.class, network.getId());
} else {
@@ -718,7 +718,7 @@ NetworkACLServiceProvider, FirewallServiceProvider, ResourceStateAdapter {
}
cidrList = r.getSourceCidrList();
if(cidrList != null){
- if(cidrList.size()>1 || r.getSourcePortEnd()!=r.getSourcePortStart()){
+ if (cidrList.size() > 1 || !r.getSourcePortEnd().equals(r.getSourcePortStart())) {
throw new ResourceUnavailableException("One CIDR and one port only please.",
Network.class, network.getId());
} else {