You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "LiKaiping415 (via GitHub)" <gi...@apache.org> on 2023/02/16 02:59:17 UTC
[GitHub] [shenyu] LiKaiping415 opened a new issue, #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
LiKaiping415 opened a new issue, #4388:
URL: https://github.com/apache/shenyu/issues/4388
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
I customized a plugin called ACL
and then I customized a hander in the selector called "AppCode" like that:
after that, I customized a hander in the rule called "权限码" like that:
When I modified the “权限码”, the old “权限码” still takes effect.
I probably looked up the source code and found that my previous handlers were still in the cache, and I thought the old handlers should disappear：
Actually in the page, I only have one rule, and the other is an old record
### Expected Behavior
When I change the value of a field in the handler, it should take effect immediately, and there should be no old records in the cache
### Steps To Reproduce
1. custom a plugin
2. custom a handler field in selector
3. custom a handler field in rule
4. modify the handler field in rule
### Environment
```markdown
ShenYu version(s):2.5.1
```
### Debug logs
_No response_
### Anything else?
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] iwangjie commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "iwangjie (via GitHub)" <gi...@apache.org>.
iwangjie commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1437780904
Hi I reproduced it according to my understanding, but it didn't succeed. Please provide more information.
First, I created a rule that contains two conditions, and now I can access both rules normally in the browser
<img width="530" alt="image" src="https://user-images.githubusercontent.com/23075587/220233262-7b5eab02-0e42-4467-a746-03dd102b86cb.png">
<img width="735" alt="image" src="https://user-images.githubusercontent.com/23075587/220233285-435ee9ee-a52c-438c-87b9-16682b6dde3c.png">
Then I changed the rule, changed or to and, and again, failed to find the rule as expected:
<img width="982" alt="image" src="https://user-images.githubusercontent.com/23075587/220233336-13c86b7b-302c-4e93-acc4-c307599fff72.png">
<img width="634" alt="image" src="https://user-images.githubusercontent.com/23075587/220233366-78fee22b-44f2-4ba5-b342-e0dc4161bb8c.png">
Finally I restored the rule back, and to change it, I changed the route of /hello100 to /hello99:
<img width="783" alt="image" src="https://user-images.githubusercontent.com/23075587/220233495-c3a491d6-7d57-46f8-b382-a7e55d75bf6b.png">
I went ahead and modified the timeout for use-case integrity, and it still works:
<img width="901" alt="image" src="https://user-images.githubusercontent.com/23075587/220233687-9f87c084-27fb-4c6b-9e11-955d62d6e225.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] LiKaiping415 closed issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "LiKaiping415 (via GitHub)" <gi...@apache.org>.
LiKaiping415 closed issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
URL: https://github.com/apache/shenyu/issues/4388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] LiKaiping415 commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "LiKaiping415 (via GitHub)" <gi...@apache.org>.
LiKaiping415 commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1433972782
> hi, it have fixed in master branch, please use master branch include shenyu-admin and shenyu-bootstrap.
ok, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] iwangjie commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "iwangjie (via GitHub)" <gi...@apache.org>.
iwangjie commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1437781517
@LiKaiping415 pls check that my use case meets your expectations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] LiKaiping415 commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "LiKaiping415 (via GitHub)" <gi...@apache.org>.
LiKaiping415 commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1437758470
> hi, it have fixed in master branch, please use master branch include shenyu-admin and shenyu-bootstrap.
@moremind @iwangjie hello，I found that the update did take effect when there was only one rule. However, when there are multiple rules, the update does not take effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1433151092
hi, it have fixed in master branch, please use master branch include shenyu-admin and shenyu-bootstrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] iwangjie commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "iwangjie (via GitHub)" <gi...@apache.org>.
iwangjie commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1432418506
It will be fixed at #4380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1437764038
@LiKaiping415 you can add my wechat to discuss this question, yijia1949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] LiKaiping415 commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "LiKaiping415 (via GitHub)" <gi...@apache.org>.
LiKaiping415 commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1433972460
>
ok,thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind commented on issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on issue #4388:
URL: https://github.com/apache/shenyu/issues/4388#issuecomment-1437763759
multiple rules? please give me your rule configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 closed issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 closed issue #4388: [BUG] The custom handler information of the custom plugin still take effect when modified
URL: https://github.com/apache/shenyu/issues/4388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org