You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2013/12/12 07:23:32 UTC
Review Request 16203: OOZIE-1624 Exclusion pattern for sharelib.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16203/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1624
https://issues.apache.org/jira/browse/OOZIE-1624
Repository: oozie
Description
-------
OOZIE-1624 Exclusion pattern for sharelib.
Diffs
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1550348
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java 1550348
http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1550348
Diff: https://reviews.apache.org/r/16203/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 16203: OOZIE-1624 Exclusion pattern for sharelib.
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16203/#review38683
-----------------------------------------------------------
now the JIRA description is consistent. thanks
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/16203/#comment70968>
typo in conditi'o'nal
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/16203/#comment70974>
Instead of a list of patterns and a O(n^2) comparison between patterns and jars later, can the Pattern be built here in the form of regex combining all the patterns? [exclusion-a-*.jar|exclusion-b-*.jar]
- Mona Chitnis
On Dec. 12, 2013, 6:23 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16203/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 6:23 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1624
> https://issues.apache.org/jira/browse/OOZIE-1624
>
>
> Repository: oozie
>
>
> Description
> -------
>
> OOZIE-1624 Exclusion pattern for sharelib.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1550348
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java 1550348
> http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1550348
>
> Diff: https://reviews.apache.org/r/16203/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 16203: OOZIE-1624 Exclusion pattern for sharelib.
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On Jan. 30, 2014, 10:37 p.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 589
> > <https://reviews.apache.org/r/16203/diff/2/?file=396840#file396840line589>
> >
> > the JIRA description mentions "oozie.action.sharelib.exclusion", and the string differs here. Why do we need exclusion per type?
Currently sharelib is specified as String actionShareLibProperty = actionConf.get(ACTION_SHARELIB_FOR + getType());
I think it's better to provide exclusion in similar way.
User can just add suffix (.exclusion) to specify exclusion for sharelib.
Will modify the jira accordingly.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16203/#review33267
-----------------------------------------------------------
On Dec. 12, 2013, 6:23 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16203/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 6:23 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1624
> https://issues.apache.org/jira/browse/OOZIE-1624
>
>
> Repository: oozie
>
>
> Description
> -------
>
> OOZIE-1624 Exclusion pattern for sharelib.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1550348
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java 1550348
> http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1550348
>
> Diff: https://reviews.apache.org/r/16203/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 16203: OOZIE-1624 Exclusion pattern for sharelib.
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16203/#review33267
-----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/16203/#comment62665>
the JIRA description mentions "oozie.action.sharelib.exclusion", and the string differs here. Why do we need exclusion per type?
- Mona Chitnis
On Dec. 12, 2013, 6:23 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16203/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 6:23 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1624
> https://issues.apache.org/jira/browse/OOZIE-1624
>
>
> Repository: oozie
>
>
> Description
> -------
>
> OOZIE-1624 Exclusion pattern for sharelib.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1550348
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java 1550348
> http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1550348
>
> Diff: https://reviews.apache.org/r/16203/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>