You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2005/06/14 00:28:45 UTC

Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Mladen; are you sure you weren't looking for 'long long', 
al la int64_t?  Falling over to the FPU is rarely the best
performance decision.

Bill

At 02:55 AM 6/13/2005, mturk@apache.org wrote:
>mturk       2005/06/13 00:55:51
>
>  Modified:    jk/native/common jk_lb_worker.c jk_shm.h jk_status.c
>  Log:
>  Use double instead size_t for trensferred/read, so that lb doesn't
>  break on trnasferred mode when 2G of data has been send/read.
>  
>  -    size_t mytraffic = 0;
>  -    size_t curmin = 0;
>  +    double mytraffic = 0;
>  +    double curmin = 0;



---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Henri Gomez wrote:
> ok, but couldn't build now from CVS, but it should works after
> jk_u64_t is defined as unsigned long long.
> 
> Since we couldn't use portable.h on iSeries, it should be elsewhere ...

Sure... I will add the need #if defined(AS400).

> 
> 
>>2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
>>Henri Gomez wrote:
>>
>>>status_strfsize ? APR ?
>>
>>Nearly: jakarta-tomcat-connectors/jk/native/common/jk_status.c ;-)
>>
>>
>>
>>>2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
>>>
>>>
>>>>Henri Gomez wrote:
>>>>
>>>>
>>>>>What do you need on iSeries ?
>>>>
>>>>Just to know what to use to have:
>>>>JK_UINT4 (unsigned long of 32 bits) and JK_UINT8 (unsigned long long of 64 bits)
>>>> and to check status_strfsize().
>>>>
>>>>
>>>>
>>>>>2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
>>>>>
>>>>>
>>>>>
>>>>>>Mladen Turk wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>>jean-frederic clere wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>Mladen Turk wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
>>>>>>>>>What will you use if the int is 64 bits?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>a long ;-)
>>>>>>>>
>>>>>>>
>>>>>>>Right :)
>>>>>>>
>>>>>>>You will need the portable.in in that case, right?
>>>>>>
>>>>>>Yes and I will ask Henri to check AS400 see jk_global.h:
>>>>>>+++
>>>>>>#if !defined(WIN32) && !defined(AS400)
>>>>>>#include "portable.h"
>>>>>>#else
>>>>>>+++
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>---------------------------------------------------------------------
>>>>>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>>>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>---------------------------------------------------------------------
>>>>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>---------------------------------------------------------------------
>>>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>>>
>>>>>
>>>>
>>>>---------------------------------------------------------------------
>>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>>
>>>>
>>>
>>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>
>>
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by Henri Gomez <he...@gmail.com>.
ok, but couldn't build now from CVS, but it should works after
jk_u64_t is defined as unsigned long long.

Since we couldn't use portable.h on iSeries, it should be elsewhere ...

>2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> Henri Gomez wrote:
> > status_strfsize ? APR ?
> 
> Nearly: jakarta-tomcat-connectors/jk/native/common/jk_status.c ;-)
> 
> 
> >
> > 2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> >
> >>Henri Gomez wrote:
> >>
> >>>What do you need on iSeries ?
> >>
> >>Just to know what to use to have:
> >>JK_UINT4 (unsigned long of 32 bits) and JK_UINT8 (unsigned long long of 64 bits)
> >>  and to check status_strfsize().
> >>
> >>
> >>>2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> >>>
> >>>
> >>>>Mladen Turk wrote:
> >>>>
> >>>>
> >>>>>jean-frederic clere wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>>>Mladen Turk wrote:
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
> >>>>>>>What will you use if the int is 64 bits?
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>a long ;-)
> >>>>>>
> >>>>>
> >>>>>Right :)
> >>>>>
> >>>>>You will need the portable.in in that case, right?
> >>>>
> >>>>Yes and I will ask Henri to check AS400 see jk_global.h:
> >>>>+++
> >>>>#if !defined(WIN32) && !defined(AS400)
> >>>>#include "portable.h"
> >>>>#else
> >>>>+++
> >>>>
> >>>>
> >>>>
> >>>>>---------------------------------------------------------------------
> >>>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >>>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >>>>>
> >>>>>
> >>>>
> >>>>---------------------------------------------------------------------
> >>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >>>>
> >>>>
> >>>
> >>>
> >>>---------------------------------------------------------------------
> >>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >>>
> >>>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >>
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Henri Gomez wrote:
> status_strfsize ? APR ?

Nearly: jakarta-tomcat-connectors/jk/native/common/jk_status.c ;-)


> 
> 2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> 
>>Henri Gomez wrote:
>>
>>>What do you need on iSeries ?
>>
>>Just to know what to use to have:
>>JK_UINT4 (unsigned long of 32 bits) and JK_UINT8 (unsigned long long of 64 bits)
>>  and to check status_strfsize().
>>
>>
>>>2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
>>>
>>>
>>>>Mladen Turk wrote:
>>>>
>>>>
>>>>>jean-frederic clere wrote:
>>>>>
>>>>>
>>>>>
>>>>>>Mladen Turk wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>>Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
>>>>>>>What will you use if the int is 64 bits?
>>>>>>
>>>>>>
>>>>>>
>>>>>>a long ;-)
>>>>>>
>>>>>
>>>>>Right :)
>>>>>
>>>>>You will need the portable.in in that case, right?
>>>>
>>>>Yes and I will ask Henri to check AS400 see jk_global.h:
>>>>+++
>>>>#if !defined(WIN32) && !defined(AS400)
>>>>#include "portable.h"
>>>>#else
>>>>+++
>>>>
>>>>
>>>>
>>>>>---------------------------------------------------------------------
>>>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>>>
>>>>>
>>>>
>>>>---------------------------------------------------------------------
>>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>>
>>>>
>>>
>>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by Henri Gomez <he...@gmail.com>.
unsigned long is 32 bits and unsigned long long is 64 bits on iSeries


2005/6/14, Henri Gomez <he...@gmail.com>:
> status_strfsize ? APR ?
> 
> 2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> > Henri Gomez wrote:
> > > What do you need on iSeries ?
> >
> > Just to know what to use to have:
> > JK_UINT4 (unsigned long of 32 bits) and JK_UINT8 (unsigned long long of 64 bits)
> >   and to check status_strfsize().
> >
> > >
> > > 2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> > >
> > >>Mladen Turk wrote:
> > >>
> > >>>jean-frederic clere wrote:
> > >>>
> > >>>
> > >>>>Mladen Turk wrote:
> > >>>>
> > >>>>
> > >>>>>Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
> > >>>>>What will you use if the int is 64 bits?
> > >>>>
> > >>>>
> > >>>>
> > >>>>a long ;-)
> > >>>>
> > >>>
> > >>>Right :)
> > >>>
> > >>>You will need the portable.in in that case, right?
> > >>
> > >>Yes and I will ask Henri to check AS400 see jk_global.h:
> > >>+++
> > >>#if !defined(WIN32) && !defined(AS400)
> > >>#include "portable.h"
> > >>#else
> > >>+++
> > >>
> > >>
> > >>>---------------------------------------------------------------------
> > >>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > >>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> > >>>
> > >>>
> > >>
> > >>---------------------------------------------------------------------
> > >>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > >>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> > >>
> > >>
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by Henri Gomez <he...@gmail.com>.
status_strfsize ? APR ?

2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> Henri Gomez wrote:
> > What do you need on iSeries ?
> 
> Just to know what to use to have:
> JK_UINT4 (unsigned long of 32 bits) and JK_UINT8 (unsigned long long of 64 bits)
>   and to check status_strfsize().
> 
> >
> > 2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> >
> >>Mladen Turk wrote:
> >>
> >>>jean-frederic clere wrote:
> >>>
> >>>
> >>>>Mladen Turk wrote:
> >>>>
> >>>>
> >>>>>Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
> >>>>>What will you use if the int is 64 bits?
> >>>>
> >>>>
> >>>>
> >>>>a long ;-)
> >>>>
> >>>
> >>>Right :)
> >>>
> >>>You will need the portable.in in that case, right?
> >>
> >>Yes and I will ask Henri to check AS400 see jk_global.h:
> >>+++
> >>#if !defined(WIN32) && !defined(AS400)
> >>#include "portable.h"
> >>#else
> >>+++
> >>
> >>
> >>>---------------------------------------------------------------------
> >>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >>>
> >>>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >>
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Henri Gomez wrote:
> What do you need on iSeries ?

Just to know what to use to have:
JK_UINT4 (unsigned long of 32 bits) and JK_UINT8 (unsigned long long of 64 bits) 
  and to check status_strfsize().

> 
> 2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> 
>>Mladen Turk wrote:
>>
>>>jean-frederic clere wrote:
>>>
>>>
>>>>Mladen Turk wrote:
>>>>
>>>>
>>>>>Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
>>>>>What will you use if the int is 64 bits?
>>>>
>>>>
>>>>
>>>>a long ;-)
>>>>
>>>
>>>Right :)
>>>
>>>You will need the portable.in in that case, right?
>>
>>Yes and I will ask Henri to check AS400 see jk_global.h:
>>+++
>>#if !defined(WIN32) && !defined(AS400)
>>#include "portable.h"
>>#else
>>+++
>>
>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>>
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by Henri Gomez <he...@gmail.com>.
What do you need on iSeries ?

2005/6/14, jean-frederic clere <jf...@fujitsu-siemens.com>:
> Mladen Turk wrote:
> > jean-frederic clere wrote:
> >
> >> Mladen Turk wrote:
> >>
> >>>
> >>> Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
> >>> What will you use if the int is 64 bits?
> >>
> >>
> >>
> >> a long ;-)
> >>
> >
> > Right :)
> >
> > You will need the portable.in in that case, right?
> 
> Yes and I will ask Henri to check AS400 see jk_global.h:
> +++
> #if !defined(WIN32) && !defined(AS400)
> #include "portable.h"
> #else
> +++
> 
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Mladen Turk wrote:
> jean-frederic clere wrote:
> 
>> Mladen Turk wrote:
>>
>>>
>>> Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
>>> What will you use if the int is 64 bits?
>>
>>
>>
>> a long ;-)
>>
> 
> Right :)
> 
> You will need the portable.in in that case, right?

Yes and I will ask Henri to check AS400 see jk_global.h:
+++
#if !defined(WIN32) && !defined(AS400)
#include "portable.h"
#else
+++

> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by Mladen Turk <mt...@apache.org>.
jean-frederic clere wrote:
> Mladen Turk wrote:
>>
>> Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
>> What will you use if the int is 64 bits?
> 
> 
> a long ;-)
>

Right :)

You will need the portable.in in that case, right?

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Mladen Turk wrote:
> jean-frederic clere wrote:
> 
>> Mladen Turk wrote:
>>
>>>
>>> Perhaps u_int32_t would be more portable.
>>
>>
>>
>> I would prefer to add in configure something like:
>> +++
>> AC_CHECK_SIZEOF(char, 1)
>> AC_CHECK_SIZEOF(int, 4)
>> AC_CHECK_SIZEOF(long, 4)
>> AC_CHECK_SIZEOF(short, 2)
>> AC_CHECK_SIZEOF(long long, 8)
>> +++
>> and testing $ac_cv_sizeof_WHATWETESTED makes sure we right one.
>>
> 
> Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
> What will you use if the int is 64 bits?

a long ;-)

> 
> Regards,
> Mladen.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by Mladen Turk <mt...@apache.org>.
jean-frederic clere wrote:
> Mladen Turk wrote:
> 
>>
>> Perhaps u_int32_t would be more portable.
> 
> 
> I would prefer to add in configure something like:
> +++
> AC_CHECK_SIZEOF(char, 1)
> AC_CHECK_SIZEOF(int, 4)
> AC_CHECK_SIZEOF(long, 4)
> AC_CHECK_SIZEOF(short, 2)
> AC_CHECK_SIZEOF(long long, 8)
> +++
> and testing $ac_cv_sizeof_WHATWETESTED makes sure we right one.
>

Yes, but all that we need is 32 bit unsigned integer for JK_UINT4
What will you use if the int is 64 bits?

Regards,
Mladen.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Mladen Turk wrote:
> jean-frederic clere wrote:
> 
>> William A. Rowe, Jr. wrote:
>>
>>> Mladen; are you sure you weren't looking for 'long long', al la 
>>> int64_t?  Falling over to the FPU is rarely the best
>>> performance decision.
>>
>>
>>
>> A little more coding is needed, because I have a related error (on 
>> ReliantUnix):
>> undefined
>>       typedef uint32_t JK_UINT4;
>>               ^
> 
> 
> Seems that the uint32_t is not inside includes referenced
> by jk_global.h. Not sure what is the possible location
> for that type on all platforms.
> 
> Perhaps u_int32_t would be more portable.

I would prefer to add in configure something like:
+++
AC_CHECK_SIZEOF(char, 1)
AC_CHECK_SIZEOF(int, 4)
AC_CHECK_SIZEOF(long, 4)
AC_CHECK_SIZEOF(short, 2)
AC_CHECK_SIZEOF(long long, 8)
+++
and testing $ac_cv_sizeof_WHATWETESTED makes sure we right one.

> 
> Regards,
> Mladen.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by Mladen Turk <mt...@apache.org>.
jean-frederic clere wrote:
> William A. Rowe, Jr. wrote:
> 
>> Mladen; are you sure you weren't looking for 'long long', al la 
>> int64_t?  Falling over to the FPU is rarely the best
>> performance decision.
> 
> 
> A little more coding is needed, because I have a related error (on 
> ReliantUnix):
> undefined
>       typedef uint32_t JK_UINT4;
>               ^

Seems that the uint32_t is not inside includes referenced
by jk_global.h. Not sure what is the possible location
for that type on all platforms.

Perhaps u_int32_t would be more portable.

Regards,
Mladen.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c jk_shm.h jk_status.c

Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
William A. Rowe, Jr. wrote:
> Mladen; are you sure you weren't looking for 'long long', 
> al la int64_t?  Falling over to the FPU is rarely the best
> performance decision.

A little more coding is needed, because I have a related error (on ReliantUnix):
+++
/home/apache20/apache20/build/libtool --silent --mode=compile cc 
-I/home/apache20/apache20/include -g -DUSE_APACHE_MD5 -I ../common  -I /include 
-I /include/unix -DSVR4 -g -DHAVE_APR  -I/home/apache20/apache20/include 
-I/home/apache20/apache20/include -g -g -DSVR4 -c ../common/jk_ajp14.c
../common/jk_md5.h    65: [error]:   CFE1020 identifier "uint32_t" is undefined
       typedef uint32_t JK_UINT4;
               ^
+++
I am going to add in configure some code to check for long long and 
sizeof(short/int/long).

> 
> Bill
> 
> At 02:55 AM 6/13/2005, mturk@apache.org wrote:
> 
>>mturk       2005/06/13 00:55:51
>>
>> Modified:    jk/native/common jk_lb_worker.c jk_shm.h jk_status.c
>> Log:
>> Use double instead size_t for trensferred/read, so that lb doesn't
>> break on trnasferred mode when 2G of data has been send/read.
>> 
>> -    size_t mytraffic = 0;
>> -    size_t curmin = 0;
>> +    double mytraffic = 0;
>> +    double curmin = 0;
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org