You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Michael Armbrust (JIRA)" <ji...@apache.org> on 2014/07/02 19:15:26 UTC

[jira] [Commented] (SPARK-2342) Evaluation helper's output type doesn't conform to input type

    [ https://issues.apache.org/jira/browse/SPARK-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050347#comment-14050347 ] 

Michael Armbrust commented on SPARK-2342:
-----------------------------------------

This does look like a typo (though maybe one that doesn't matter due to erasure?).  That said, if you make a PR I'll certainly merge it.  Thanks!

> Evaluation helper's output type doesn't conform to input type
> -------------------------------------------------------------
>
>                 Key: SPARK-2342
>                 URL: https://issues.apache.org/jira/browse/SPARK-2342
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 1.0.0
>            Reporter: Yijie Shen
>            Priority: Minor
>              Labels: easyfix
>
> In sql/catalyst/org/apache/spark/sql/catalyst/expressions.scala
> {code}protected final def n2 ( i: Row, e1: Expression, e2: Expression, f: ((Numeric[Any], Any, Any) => Any)): Any  {code}
> is intended  to do computations for Numeric add/Minus/Multipy.
> Just as the comment suggest : {quote}Those expressions are supposed to be in the same data type, and also the return type.{quote}
> But in code, function f was casted to function signature:
> {code}(Numeric[n.JvmType], n.JvmType, n.JvmType) => Int{code}
> I thought it as a typo and the correct should be:
> {code}(Numeric[n.JvmType], n.JvmType, n.JvmType) => n.JvmType{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)