You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by queeniema <gi...@git.apache.org> on 2016/04/12 02:40:32 UTC
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
GitHub user queeniema opened a pull request:
https://github.com/apache/incubator-quarks-website/pull/39
[QUARKS-141] Update existing recipes to use SimpleSimulatedSensor and SimulatedTemperatureSensor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/queeniema/incubator-quarks-website QUARKS-141
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks-website/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 15b71492427c03a533b24a9424e3b92545337808
Author: Queenie Ma <qu...@gmail.com>
Date: 2016-04-12T00:39:10Z
[QUARKS-141] Update existing recipes to use SimpleSimulatedSensor and SimulatedTemperatureSensor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks-website/pull/39#discussion_r59368477
--- Diff: site/recipes/recipe_different_processing_against_stream.md ---
@@ -10,27 +10,35 @@ In this instance, we can take the stream of mileage sensor readings and apply mu
## Setting up the application
-We assume that the environment has been set up following the steps outlined in the [Getting Started Guide](../docs/quarks-getting-started). Let's begin by creating a `DirectProvider` and `Topology`. We choose a `DevelopmentProvider` so that we can view the topology graph using the console URL (refer to the [Application Console](../docs/console) page for a more detailed explanation of this provider). The initial mileage value and the number of miles in a typical delivery route have also been defined.
+We assume that the environment has been set up following the steps outlined in the [Getting started guide](../docs/quarks-getting-started). Let's begin by creating a `DirectProvider` and `Topology`. We choose a `DevelopmentProvider` so that we can view the topology graph using the console URL (refer to the [Application console](../docs/console) page for a more detailed explanation of this provider). The gas mileage bounds, initial mileage value, and the number of miles in a typical delivery route have also been defined.
```java
import java.text.DecimalFormat;
- import java.util.Random;
import java.util.concurrent.TimeUnit;
import com.google.gson.JsonObject;
+ import quarks.analytics.sensors.Ranges;
import quarks.console.server.HttpServer;
import quarks.providers.development.DevelopmentProvider;
import quarks.providers.direct.DirectProvider;
+ import quarks.samples.utils.sensor.SimpleSimulatedSensor;
import quarks.topology.TStream;
import quarks.topology.Topology;
public class ApplyDifferentProcessingAgainstStream {
/**
- * Hypothetical values for the initial gas mileage and the
- * number of miles in a typical delivery route
+ * Gas mileage value bounds
--- End diff --
~nit: since you're in here improving things, no good deed goes unpunished :-), the first time I looked at this recipe, I was a initially confused because it uses the term "mileage" in variety of places (e.g., stream name, constants) where the values are really "miles per gallon"; the definition of "mileage" means distance. Consider renaming things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
Posted by ddebrunner <gi...@git.apache.org>.
Github user ddebrunner commented on a diff in the pull request:
https://github.com/apache/incubator-quarks-website/pull/39#discussion_r59373891
--- Diff: site/recipes/recipe_different_processing_against_stream.md ---
@@ -10,27 +10,35 @@ In this instance, we can take the stream of mileage sensor readings and apply mu
## Setting up the application
-We assume that the environment has been set up following the steps outlined in the [Getting Started Guide](../docs/quarks-getting-started). Let's begin by creating a `DirectProvider` and `Topology`. We choose a `DevelopmentProvider` so that we can view the topology graph using the console URL (refer to the [Application Console](../docs/console) page for a more detailed explanation of this provider). The initial mileage value and the number of miles in a typical delivery route have also been defined.
+We assume that the environment has been set up following the steps outlined in the [Getting started guide](../docs/quarks-getting-started). Let's begin by creating a `DirectProvider` and `Topology`. We choose a `DevelopmentProvider` so that we can view the topology graph using the console URL (refer to the [Application console](../docs/console) page for a more detailed explanation of this provider). The gas mileage bounds, initial mileage value, and the number of miles in a typical delivery route have also been defined.
```java
import java.text.DecimalFormat;
- import java.util.Random;
import java.util.concurrent.TimeUnit;
import com.google.gson.JsonObject;
+ import quarks.analytics.sensors.Ranges;
import quarks.console.server.HttpServer;
import quarks.providers.development.DevelopmentProvider;
import quarks.providers.direct.DirectProvider;
+ import quarks.samples.utils.sensor.SimpleSimulatedSensor;
import quarks.topology.TStream;
import quarks.topology.Topology;
public class ApplyDifferentProcessingAgainstStream {
/**
- * Hypothetical values for the initial gas mileage and the
- * number of miles in a typical delivery route
+ * Gas mileage value bounds
--- End diff --
"gas mileage" is a term used for fuel economy, may be a US centric term though, but then again so is "miles per gallon".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks-website/pull/39#discussion_r59376345
--- Diff: site/recipes/recipe_different_processing_against_stream.md ---
@@ -10,27 +10,35 @@ In this instance, we can take the stream of mileage sensor readings and apply mu
## Setting up the application
-We assume that the environment has been set up following the steps outlined in the [Getting Started Guide](../docs/quarks-getting-started). Let's begin by creating a `DirectProvider` and `Topology`. We choose a `DevelopmentProvider` so that we can view the topology graph using the console URL (refer to the [Application Console](../docs/console) page for a more detailed explanation of this provider). The initial mileage value and the number of miles in a typical delivery route have also been defined.
+We assume that the environment has been set up following the steps outlined in the [Getting started guide](../docs/quarks-getting-started). Let's begin by creating a `DirectProvider` and `Topology`. We choose a `DevelopmentProvider` so that we can view the topology graph using the console URL (refer to the [Application console](../docs/console) page for a more detailed explanation of this provider). The gas mileage bounds, initial mileage value, and the number of miles in a typical delivery route have also been defined.
```java
import java.text.DecimalFormat;
- import java.util.Random;
import java.util.concurrent.TimeUnit;
import com.google.gson.JsonObject;
+ import quarks.analytics.sensors.Ranges;
import quarks.console.server.HttpServer;
import quarks.providers.development.DevelopmentProvider;
import quarks.providers.direct.DirectProvider;
+ import quarks.samples.utils.sensor.SimpleSimulatedSensor;
import quarks.topology.TStream;
import quarks.topology.Topology;
public class ApplyDifferentProcessingAgainstStream {
/**
- * Hypothetical values for the initial gas mileage and the
- * number of miles in a typical delivery route
+ * Gas mileage value bounds
--- End diff --
"gas mileage" would be fine. it's the naked "mileage" (e.g. TStream<Double> mileage) that I found confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/39#issuecomment-209722297
Nope, it's standard github workflow for the user to rebase their PR's fork's branch with (conflicting) fresh master content.
```
$ cd ~/git/incubator-quarks-website # the fork's local clone
$ git fetch upstream master
$ git checkout master
$ git rebase upstream/master # clone's master is now up to date
$ git push # the fork's master is now up to date
# fwiw the above is what the earlier mentioned merge-pr's sister script "rebase-master" does :-)
$ git checkout QUARKS-141
$ git rebase master
... resolve any conflicts as noted by "git status"
# the clone's QUARKS-141 is now up to date
$ git push -f # the fork's QUARKS-141 is now up to date
# if no other conflicting changes have happened on master, the PR should now report no conflicts
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
Posted by queeniema <gi...@git.apache.org>.
Github user queeniema commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/39#issuecomment-210016819
@home4slc and @dlaboss, thanks for bringing this up. I will rebase my branch to master and push.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
Posted by queeniema <gi...@git.apache.org>.
Github user queeniema commented on a diff in the pull request:
https://github.com/apache/incubator-quarks-website/pull/39#discussion_r59398119
--- Diff: site/recipes/recipe_different_processing_against_stream.md ---
@@ -10,27 +10,35 @@ In this instance, we can take the stream of mileage sensor readings and apply mu
## Setting up the application
-We assume that the environment has been set up following the steps outlined in the [Getting Started Guide](../docs/quarks-getting-started). Let's begin by creating a `DirectProvider` and `Topology`. We choose a `DevelopmentProvider` so that we can view the topology graph using the console URL (refer to the [Application Console](../docs/console) page for a more detailed explanation of this provider). The initial mileage value and the number of miles in a typical delivery route have also been defined.
+We assume that the environment has been set up following the steps outlined in the [Getting started guide](../docs/quarks-getting-started). Let's begin by creating a `DirectProvider` and `Topology`. We choose a `DevelopmentProvider` so that we can view the topology graph using the console URL (refer to the [Application console](../docs/console) page for a more detailed explanation of this provider). The gas mileage bounds, initial mileage value, and the number of miles in a typical delivery route have also been defined.
```java
import java.text.DecimalFormat;
- import java.util.Random;
import java.util.concurrent.TimeUnit;
import com.google.gson.JsonObject;
+ import quarks.analytics.sensors.Ranges;
import quarks.console.server.HttpServer;
import quarks.providers.development.DevelopmentProvider;
import quarks.providers.direct.DirectProvider;
+ import quarks.samples.utils.sensor.SimpleSimulatedSensor;
import quarks.topology.TStream;
import quarks.topology.Topology;
public class ApplyDifferentProcessingAgainstStream {
/**
- * Hypothetical values for the initial gas mileage and the
- * number of miles in a typical delivery route
+ * Gas mileage value bounds
--- End diff --
I can see how that would be confusing. I'll update references to "mileage" to "miles per gallon".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quarks-website/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-141] Update existin...
Posted by home4slc <gi...@git.apache.org>.
Github user home4slc commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/39#issuecomment-209695175
HI Queenie - do you know how to resolve the conflicts? I don't know if this is something only a committer can do??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---