You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Suraj Khurana <su...@hotwax.co> on 2020/05/01 04:54:41 UTC
Re: [ofbiz-framework] branch trunk updated: Improved: Converted all
ShipmentReceiptRole service from crud to entity-auto (#85)
Thanks Pawan.
It is done in rev a92136c662b2a150274b7a9aaea2c3117488e599
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Thu, Apr 30, 2020 at 9:54 PM Pawan Verma <pa...@hotwaxsystems.com>
wrote:
> Hi Suraj,
>
> You've missed to add default-entity-name for the entity-auto engine for the
> above services.
>
> Could you please handle?
> --
> Thanks & Regards
> Pawan Verma
> Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> http://www.hotwaxsystems.com
>
>
> On Thu, Apr 30, 2020 at 5:05 PM <su...@apache.org> wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > surajk pushed a commit to branch trunk
> > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> >
> >
> > The following commit(s) were added to refs/heads/trunk by this push:
> > new e1a16aa Improved: Converted all ShipmentReceiptRole service
> from
> > crud to entity-auto (#85)
> > e1a16aa is described below
> >
> > commit e1a16aa9fe4bacded92a0c4c34a0af7c02d0a325
> > Author: Suraj Khurana <64...@users.noreply.github.com>
> > AuthorDate: Thu Apr 30 17:05:39 2020 +0530
> >
> > Improved: Converted all ShipmentReceiptRole service from crud to
> > entity-auto (#85)
> >
> > * Improved: Converted all ShipmentReceiptRole service from crud to
> > entity-auto
> > (OFBIZ-11614)
> > ---
> > .../shipment/receipt/ShipmentReceiptServices.xml | 15
> > ---------------
> > applications/product/servicedef/services.xml | 2 +-
> > applications/product/servicedef/services_shipment.xml | 18
> > ++++++------------
> > 3 files changed, 7 insertions(+), 28 deletions(-)
> >
> > diff --git
> >
> a/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
> >
> b/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
> > index 2dade39..4334dc5 100644
> > ---
> >
> a/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
> > +++
> >
> b/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
> > @@ -63,21 +63,6 @@ under the License.
> > <field-to-result field="affectAccounting"
> > result-name="affectAccounting"/>
> > </simple-method>
> >
> > - <simple-method method-name="createShipmentReceiptRole"
> > short-description="Create a ShipmentReceipt Role">
> > - <make-value entity-name="ShipmentReceiptRole"
> > value-field="newEntity"/>
> > - <set-pk-fields map="parameters" value-field="newEntity"/>
> > - <set-nonpk-fields map="parameters" value-field="newEntity"/>
> > -
> > - <create-value value-field="newEntity"/>
> > - </simple-method>
> > -
> > - <simple-method method-name="removeShipmentReceiptRole"
> > short-description="Remove a ShipmentReceipt Role">
> > - <make-value entity-name="ShipmentReceiptRole"
> > value-field="lookupPKMap"/>
> > - <set-pk-fields map="parameters" value-field="lookupPKMap"/>
> > - <find-by-primary-key entity-name="ShipmentReceiptRole"
> > map="lookupPKMap" value-field="lookedUpValue"/>
> > - <remove-value value-field="lookedUpValue"/>
> > - </simple-method>
> > -
> > <simple-method method-name="receiveInventoryProduct"
> > short-description="Receive Inventory in new Inventory Item(s)">
> > <!-- NOTES
> > - for serialized items with a serial number passed in: the
> > quantityAccepted _should_ always be 1
> > diff --git a/applications/product/servicedef/services.xml
> > b/applications/product/servicedef/services.xml
> > index 6015638..46a8f7c 100644
> > --- a/applications/product/servicedef/services.xml
> > +++ b/applications/product/servicedef/services.xml
> > @@ -1003,7 +1003,7 @@ under the License.
> > <description>Create ProductFeature-DataResource</description>
> > <auto-attributes include="pk" mode="IN" optional="false"/>
> > </service>
> > - <service name="removeProductFeatureDataResource"
> > default-entity-name="ProductFeatureDataResource" engine="entity-auto"
> > invoke="remove" auth="true">
> > + <service name="removeProductFeatureDataResource"
> > default-entity-name="ProductFeatureDataResource" engine="entity-auto"
> > invoke="delete" auth="true">
> > <description>Remove ProductFeature-DataResource</description>
> > <auto-attributes include="pk" mode="IN" optional="false"/>
> > </service>
> > diff --git a/applications/product/servicedef/services_shipment.xml
> > b/applications/product/servicedef/services_shipment.xml
> > index 1b33dc6..ff49a88 100644
> > --- a/applications/product/servicedef/services_shipment.xml
> > +++ b/applications/product/servicedef/services_shipment.xml
> > @@ -915,23 +915,17 @@ under the License.
> > <attribute name="statusId" type="String" mode="IN"
> > optional="true"/>
> > </service>
> >
> > - <service name="interfaceShipmentReceiptRole" engine="interface"
> > location="" invoke="">
> > - <description>Interface for ShipmentReceiptRole</description>
> > - <attribute name="receiptId" type="String" mode="IN"
> > optional="false"/>
> > - <attribute name="partyId" type="String" mode="IN"
> > optional="false"/>
> > - <attribute name="roleTypeId" type="String" mode="IN"
> > optional="false"/>
> > - </service>
> > - <service name="createShipmentReceiptRole" engine="simple"
> > -
> >
> location="component://product/minilang/shipment/receipt/ShipmentReceiptServices.xml"
> > invoke="createShipmentReceiptRole" auth="true">
> > + <service name="createShipmentReceiptRole" engine="entity-auto"
> > invoke="create" auth="true">
> > <description>Create a ShipmentReceipt Role entry</description>
> > <permission-service service-name="facilityGenericPermission"
> > main-action="CREATE"/>
> > - <implements service="interfaceShipmentReceiptRole"/>
> > + <auto-attributes include="pk" mode="INOUT" optional="false"/>
> > + <auto-attributes include="nonpk" mode="IN" optional="true"/>
> > </service>
> > - <service name="removeShipmentReceiptRole" engine="simple"
> > -
> >
> location="component://product/minilang/shipment/receipt/ShipmentReceiptServices.xml"
> > invoke="removeShipmentReceiptRole" auth="true">
> > + <service name="removeShipmentReceiptRole" engine="entity-auto"
> > invoke="delete" auth="true">
> > <description>Remove a ShipmentReceipt Role entry</description>
> > <permission-service service-name="facilityGenericPermission"
> > main-action="DELETE"/>
> > - <implements service="interfaceShipmentReceiptRole"/>
> > + <auto-attributes include="pk" mode="IN" optional="false"/>
> > + <auto-attributes include="nonpk" mode="IN" optional="true"/>
> > </service>
> >
> > <!-- Shipment Estimate (Rate) Services -->
> >
> >
>