[GitHub] [pulsar] nicoloboschi opened a new pull request #14195: [test] do not rely on InetSocketAddress#toString() in tests

[GitBox <gi...@apache.org>]

nicoloboschi opened a new pull request #14195:
URL: https://github.com/apache/pulsar/pull/14195


   ### Motivation
   There are some tests that assert the equality of two `InetSocketAddress` instances by using the `toString()` method.
   Since JDK14, the `toString()` has changed for unresolved ´InetSocketAddress´ instances. See https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8225499
   
   ### Modifications
   
   * Assert equality based on `equals` method.
   
   Note: I manually checked the usage of toString in the `src` codebase and I haven't found implementations that rely on the `toString()` method
   
   ### Documentation
    
   - [x] `no-need-doc` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall merged pull request #14195: [test] do not rely on InetSocketAddress#toString() in tests

[GitBox <gi...@apache.org>]

michaeljmarshall merged pull request #14195:
URL: https://github.com/apache/pulsar/pull/14195


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org