You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/17 15:21:04 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #8240: [database] Improve form and API validation for invalid URI

dpgaspar opened a new pull request #8240: [database] Improve form and API validation for invalid URI
URL: https://github.com/apache/incubator-superset/pull/8240
 
 
   ### CATEGORY
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Improves database connection form validation (and API data submission). Currently a user would only know about URI parse validation errors after form submission, with this change an error is shown to the user while still editing the form. A properly formatted error is also return on the new API referencing the column `sqlalchemy_uri`
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org