You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/11/17 22:27:43 UTC
Review Request 40403: Added streaming and construction methods for
URI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40403/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
Added streaming and construction methods for URI.
Diffs
-----
include/mesos/uri/uri.hpp PRE-CREATION
src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49
src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
src/tests/uri_tests.cpp PRE-CREATION
src/uri/schemes/file.hpp PRE-CREATION
src/uri/schemes/http.hpp PRE-CREATION
src/uri/utils.hpp PRE-CREATION
src/uri/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40403/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 40403: Added streaming and construction methods
for URI.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40403/#review106961
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40250, 40251, 40252, 40274, 40253, 40305, 40403]
All tests passed.
- Mesos ReviewBot
On Nov. 17, 2015, 9:27 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40403/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 9:27 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added streaming and construction methods for URI.
>
>
> Diffs
> -----
>
> include/mesos/uri/uri.hpp PRE-CREATION
> src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49
> src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
> src/tests/uri_tests.cpp PRE-CREATION
> src/uri/schemes/file.hpp PRE-CREATION
> src/uri/schemes/http.hpp PRE-CREATION
> src/uri/utils.hpp PRE-CREATION
> src/uri/utils.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 40403: Added streaming and construction methods
for URI.
Posted by Jie Yu <yu...@gmail.com>.
> On Nov. 18, 2015, 7:54 p.m., Vinod Kone wrote:
> > src/uri/schemes/http.hpp, line 38
> > <https://reviews.apache.org/r/40403/diff/1/?file=1128886#file1128886line38>
> >
> > consider merging `uri/schemes/*` and `src/uri/utils.cpp` into a single `src/uri.cpp` file.
I thought about that before. two reasons why I didn't do that:
1) you might introduce more ane more schemes. One file each scheme sounds more scalable. (we might want to add parse functions as well for each scheme).
2) I don't want to introduce a src/uri.hpp which might get confused with mesos/uri/uri.hpp.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40403/#review107074
-----------------------------------------------------------
On Nov. 18, 2015, 11:25 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40403/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 11:25 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3924
> https://issues.apache.org/jira/browse/MESOS-3924
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added streaming and construction methods for URI.
>
>
> Diffs
> -----
>
> include/mesos/uri/uri.hpp PRE-CREATION
> src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49
> src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
> src/tests/uri_tests.cpp PRE-CREATION
> src/uri/schemes/file.hpp PRE-CREATION
> src/uri/schemes/http.hpp PRE-CREATION
> src/uri/utils.hpp PRE-CREATION
> src/uri/utils.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 40403: Added streaming and construction methods
for URI.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40403/#review107074
-----------------------------------------------------------
Ship it!
src/uri/schemes/http.hpp (line 38)
<https://reviews.apache.org/r/40403/#comment166001>
consider merging `uri/schemes/*` and `src/uri/utils.cpp` into a single `src/uri.cpp` file.
- Vinod Kone
On Nov. 17, 2015, 9:27 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40403/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 9:27 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added streaming and construction methods for URI.
>
>
> Diffs
> -----
>
> include/mesos/uri/uri.hpp PRE-CREATION
> src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49
> src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
> src/tests/uri_tests.cpp PRE-CREATION
> src/uri/schemes/file.hpp PRE-CREATION
> src/uri/schemes/http.hpp PRE-CREATION
> src/uri/utils.hpp PRE-CREATION
> src/uri/utils.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 40403: Added streaming and construction methods
for URI.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40403/
-----------------------------------------------------------
(Updated Nov. 18, 2015, 11:25 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3924
https://issues.apache.org/jira/browse/MESOS-3924
Repository: mesos
Description
-------
Added streaming and construction methods for URI.
Diffs
-----
include/mesos/uri/uri.hpp PRE-CREATION
src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49
src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
src/tests/uri_tests.cpp PRE-CREATION
src/uri/schemes/file.hpp PRE-CREATION
src/uri/schemes/http.hpp PRE-CREATION
src/uri/utils.hpp PRE-CREATION
src/uri/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40403/diff/
Testing
-------
make check
Thanks,
Jie Yu