[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #134: Adding Drop and Rename APIs to Tables interface.

[GitBox <gi...@apache.org>]

prodeezy commented on a change in pull request #134: Adding Drop and Rename APIs to Tables interface.
URL: https://github.com/apache/incubator-iceberg/pull/134#discussion_r266741633
 
 

 ##########
 File path: api/src/main/java/com/netflix/iceberg/Tables.java
 ##########
 @@ -43,4 +43,13 @@ Table create(Schema schema,
                String tableIdentifier);
 
   Table load(String tableIdentifier);
+
+  /**
+   * Drop a table from iceberg catalog, the underlying implementation
+   * may or may not drop the corresponding metadata and data.
+   * @param tableIdentifier
+   */
+  void drop(String tableIdentifier);
 
 Review comment:
   add a flag or properties map maybe to allow expressing options for dropping data/metadata so that the contract is clearer? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org