You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/02/16 15:24:25 UTC
[GitHub] cstamas commented on a change in pull request #137: URIBuilder and
URIUtils improvements
cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements
URL: https://github.com/apache/httpcomponents-client/pull/137#discussion_r257464571
##########
File path: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheKeyGenerator.java
##########
@@ -63,45 +114,23 @@
* @return String the extracted URI
*/
public String getURI(final HttpHost host, final HttpRequest req) {
- if (isRelativeRequest(req)) {
- return canonicalizeUri(String.format("%s%s", host.toString(), req.getRequestLine().getUri()));
+ try {
+ final URI uri = normalize(getRequestUri(req, host));
Review comment:
Why `uri` local var?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org