[GitHub] [superset] geido commented on a change in pull request #15560: refactor: icon to icons for headeractionsdropdown

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #15560:
URL: https://github.com/apache/superset/pull/15560#discussion_r665489394



##########
File path: superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
##########
@@ -88,6 +88,9 @@ const MENU_KEYS = {
 
 const DropdownButton = styled.div`
   margin-left: ${({ theme }) => theme.gridUnit * 2.5}px;
+  span {
+    color: ${({ theme }) => theme.colors.grayscale.base};

Review comment:
       I think this opens up the discussion whether we should prefer passing the color down using the Icons prop `iconColor` or do as you are doing here.
   
   In this case, though, this is the default color of the icons and I think this should be set as the default in the Icons component instead of having to repeat it all the time. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org