You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanju1010 <gi...@git.apache.org> on 2015/12/07 13:49:54 UTC
[GitHub] cloudstack pull request: Marvin test to verify that adding TCP por...
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1183
Marvin test to verify that adding TCP ports 500,4500 and 1701 in vpn should not fail
Please refer to JIRA ticket for more details
https://issues.apache.org/jira/browse/CLOUDSTACK-9117
Following is the result info:
Test to add TCP Port Forwarding rule for specific ports(500,1701 and 4500) in VPN ... === TestName: test_08_add_TCP_PF_Rule_In_VPN | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 166.799s
OK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanju1010/cloudstack tcpports
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1183
----
commit d09ebac31892cf24246801f129c7325692efcbd4
Author: sanjeevn <sa...@citrix.com>
Date: 2015-12-07T12:25:50Z
Marvin test to verify that adding TCP ports 500,4500 and 1701
in vpn should not fail
Bug-Id: CS-43653
Reviewed-by: Self
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Marvin test to verify that adding TCP por...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1183#issuecomment-216206911
@sanju1010 can you rebase against latest master and share state of your PR, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1183: Marvin test to verify that adding TCP ports 5...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1183: Marvin test to verify that adding TCP ports 500,4500...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1183
### ACS CI BVT Run
**Sumarry:**
Build Number 112
Hypervisor xenserver
NetworkType Advanced
Passed=68
Failed=5
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_vpc_vpn.py
* ContextSuite context=TestRVPCSite2SiteVpn>:setup Failing since 9 runs
* ContextSuite context=TestVpcRemoteAccessVpn>:setup Failing since 9 runs
* ContextSuite context=TestVpcSite2SiteVpn>:setup Failing since 9 runs
* test_volumes.py
* test_06_download_detached_volume Failed
* test_vm_life_cycle.py
* test_10_attachAndDetach_iso Failed
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Marvin test to verify that adding TCP por...
Posted by pavanb018 <gi...@git.apache.org>.
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1183#discussion_r60533545
--- Diff: test/integration/component/test_vpn_users.py ---
@@ -451,3 +453,64 @@ def test_07_add_VPN_user_domain_admin(self):
self.fail("Domain admin should be allowed to create VPN user: %s" %
e)
return
+
+ @attr(tags=["advanced", "advancedns"], required_hardware="false")
+ def test_08_add_TCP_PF_Rule_In_VPN(self):
+ """
+ Test to add TCP Port Forwarding rule for specific ports(500,1701 and 4500) in VPN
+ """
+ # Steps for verification
+ # 1. Enable vpn on SourceNAT IP address
+ # 2. Configure PF with TCP ports 500,1701 and 4500. It should be allowed
+ # Should not conflict with UPD ports used for VPN
+
+ vm_res = VirtualMachine.list(
+ self.apiclient,
+ id=self.virtual_machine.id,
+ listall=True
+ )
+ self.assertEqual(
+ validateList(vm_res)[0],
+ PASS,
+ "Failed to list virtual machine"
+ )
+ network_id = vm_res[0].nic[0].networkid
+ src_nat_list = PublicIPAddress.list(
+ self.apiclient,
+ account=self.account.name,
+ domainid=self.account.domainid,
+ listall=True,
+ issourcenat=True,
+ associatednetworkid=network_id
+ )
+ self.assertEqual(
+ validateList(src_nat_list)[0],
+ PASS,
+ "Failed to list source nat ip address"
+ )
+ ip = src_nat_list[0]
+ try:
+ Vpn.create(
+ self.apiclient,
+ publicipid=ip.id,
+ account=self.account.name,
+ domainid=self.account.domainid,
+ )
+ except Exception as e:
+ self.fail("Failed to enable vpn on SourceNAT IP with error: %s" % e)
+
+ #Create PF rule with TCP ports 500,4500 and 1701
+ self.services['natrule']['protocol']="TCP"
+ for port in [500, 4500, 1701]:
+ self.services['natrule']['privateport'] = port
+ self.services['natrule']['publicport'] = port
+ try:
+ NATRule.create(
+ self.apiclient,
+ self.virtual_machine,
+ self.services["natrule"],
+ ip.id
+ )
+ except Exception as e:
+ self.fail("Creating PF rule for TCP port %s in VPN failed : %s" % (port, e))
--- End diff --
Can you please add assert cases here as well for the PF rules ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1183: Marvin test to verify that adding TCP ports 500,4500...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1183
failures are note related. merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Marvin test to verify that adding TCP ports 500,450...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1183
Test to add TCP Port Forwarding rule for specific ports(500,1701 and 4500) in VPN ... === TestName: test_08_add_TCP_PF_Rule_In_VPN | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 574.873s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Marvin test to verify that adding TCP por...
Posted by pavanb018 <gi...@git.apache.org>.
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1183#discussion_r60532757
--- Diff: test/integration/component/test_vpn_users.py ---
@@ -451,3 +453,64 @@ def test_07_add_VPN_user_domain_admin(self):
self.fail("Domain admin should be allowed to create VPN user: %s" %
e)
return
+
+ @attr(tags=["advanced", "advancedns"], required_hardware="false")
+ def test_08_add_TCP_PF_Rule_In_VPN(self):
+ """
+ Test to add TCP Port Forwarding rule for specific ports(500,1701 and 4500) in VPN
+ """
+ # Steps for verification
+ # 1. Enable vpn on SourceNAT IP address
+ # 2. Configure PF with TCP ports 500,1701 and 4500. It should be allowed
+ # Should not conflict with UPD ports used for VPN
+
+ vm_res = VirtualMachine.list(
+ self.apiclient,
+ id=self.virtual_machine.id,
+ listall=True
+ )
+ self.assertEqual(
+ validateList(vm_res)[0],
+ PASS,
+ "Failed to list virtual machine"
+ )
+ network_id = vm_res[0].nic[0].networkid
+ src_nat_list = PublicIPAddress.list(
+ self.apiclient,
+ account=self.account.name,
+ domainid=self.account.domainid,
+ listall=True,
+ issourcenat=True,
+ associatednetworkid=network_id
+ )
+ self.assertEqual(
+ validateList(src_nat_list)[0],
+ PASS,
+ "Failed to list source nat ip address"
+ )
+ ip = src_nat_list[0]
+ try:
+ Vpn.create(
+ self.apiclient,
+ publicipid=ip.id,
+ account=self.account.name,
+ domainid=self.account.domainid,
+ )
+ except Exception as e:
+ self.fail("Failed to enable vpn on SourceNAT IP with error: %s" % e)
+
--- End diff --
@sanju1010 Can you please add an assert case to confirm that the VPN is actually created ? That will make sure that the UDP ports are actually used by VPN and then same ports can be used by TCP in PF ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---