You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/21 18:52:14 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #2094: Pass generate_decimal256_case integration test, add `DataType::Decimal256`

alamb commented on code in PR #2094:
URL: https://github.com/apache/arrow-rs/pull/2094#discussion_r927006745


##########
arrow/src/datatypes/datatype.rs:
##########
@@ -195,6 +195,8 @@ pub enum DataType {
     ///
     /// For example the number 123.45 has precision 5 and scale 2.
     Decimal(usize, usize),
+    /// Exact decimal value with 256 bits width
+    Decimal256(usize, usize),

Review Comment:
   > And, yea, we need to rename Decimal to Decimal128. 
   
   I agree
   
   >  I may work on it in another PR.
   
   Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org