You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/12/31 10:26:34 UTC

Review Request 29506: Upgrade Progress: Show "Ignore and Continue" and "Retry" buttons based on the API response

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29506/
-----------------------------------------------------------

Review request for Ambari and Andriy Babiichuk.

Bugs: AMBARI-8695
https://issues.apache.org/jira/browse/AMBARI-8695

Repository: ambari

Description
-------

Allow Retry - mark a stage (upgrade item) to allow any failed task to be retried. This means that if a failure occurs during the execution of the task then the stage & task will transition to HOLDING_FAILED. Once in the HOLDING_FAILED state, the stage can be pushed to PENDING (retry) or FAILED. Transitioning the stage to FAILED will cause the remaining tasks in that stage to be ABORTED. It never makes sense to allow the remaining tasks of a stage to continue executing after the stage has been accepted as FAILED. However, the remaining stages of the upgrade request may be allowed execute...
Skippable - mark a stage to allow it to be skipped in the event of a failure so that the remaining stages may still execute. This means that when a stage state is set to FAILED, it will not trigger the remaining stages of the request to abort.

Diffs
-----

ambari-web/app/templates/main/admin/stack_upgrade/upgrade_group.hbs 729bcf2
ambari-web/app/utils/helper.js 844324d
ambari-web/app/views/main/admin/stack_upgrade/upgrade_group_view.js 2964313
ambari-web/test/views/main/admin/stack_upgrade/upgrade_group_view_test.js 3048d90

Diff: https://reviews.apache.org/r/29506/diff/

Testing
-------

5207 tests complete (9 seconds)
60 tests pending

Thanks,

Andrii Tkach

Re: Review Request 29506: Upgrade Progress: Show "Ignore and Continue" and "Retry" buttons based on the API response

Posted by Andriy Babiichuk <ab...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29506/#review66458
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Дек. 31, 2014, 9:26 д.п., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29506/
> -----------------------------------------------------------
> 
> (Updated Дек. 31, 2014, 9:26 д.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-8695
>     https://issues.apache.org/jira/browse/AMBARI-8695
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Allow Retry - mark a stage (upgrade item) to allow any failed task to be retried. This means that if a failure occurs during the execution of the task then the stage & task will transition to HOLDING_FAILED. Once in the HOLDING_FAILED state, the stage can be pushed to PENDING (retry) or FAILED. Transitioning the stage to FAILED will cause the remaining tasks in that stage to be ABORTED. It never makes sense to allow the remaining tasks of a stage to continue executing after the stage has been accepted as FAILED. However, the remaining stages of the upgrade request may be allowed execute...
> Skippable - mark a stage to allow it to be skipped in the event of a failure so that the remaining stages may still execute. This means that when a stage state is set to FAILED, it will not trigger the remaining stages of the request to abort.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_group.hbs 729bcf2 
>   ambari-web/app/utils/helper.js 844324d 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_group_view.js 2964313 
>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_group_view_test.js 3048d90 
> 
> Diff: https://reviews.apache.org/r/29506/diff/
> 
> 
> Testing
> -------
> 
>  5207 tests complete (9 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>