Re: [PR] [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status [spark]

["mstebelev (via GitHub)" <gi...@apache.org>]

mstebelev commented on PR #36564:
URL: https://github.com/apache/spark/pull/36564#issuecomment-1774214202

   Hi @AngersZhuuuu. I came across problems with this changes after updating to spark 3.4
   I write data to iceberg table with S3 backend and the data upload happens in dataWriter.commit() after coordinator.canCommit was called. So if uploading to S3 fails for some reason, the task fails and the partition data can't be uploaded anymore event in the task's retries, because the failed task remains to be the assigned commiter.
   Looks like usually data writing is idempotent, because each partition is written into a separate file and you always can do it again in retrying task without data duplication. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org