You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Alan Gates (JIRA)" <ji...@apache.org> on 2011/04/11 18:26:05 UTC
[jira] [Created] (PIG-1987) -dryrun does not work with set
-dryrun does not work with set
------------------------------
Key: PIG-1987
URL: https://issues.apache.org/jira/browse/PIG-1987
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.9.0
Reporter: Alan Gates
Assignee: Xuefu Zhang
Fix For: 0.9.0
The following script works
{code}
set default_parallel 10;
import 'scripts/macro1.pig';
import 'scripts/macro2.pig';
wlogs = load 'clicks' as (url, pageid, timestamp);
good = spam_filter(wlogs, url);
{code}
But if -dryrun is added to the command line it returns the error:
{code}
ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax error, unexpected symbol at or near 'set'
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1987) -dryrun does not work with set
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019985#comment-13019985 ]
Xuefu Zhang commented on PIG-1987:
----------------------------------
For patch PIG-1987.patch, it appears to me that dryrun() method in QueryParserDriver has nothing to do with the what QueryParserDriver is doing. Right now there is loop in calling stack: Main -> QueryParserDriver -> DryrunParser -> QueryParserDriver, which can be made better by moving dryrun() method from QueryParserDriver to DryrunDriver itself. With that, the class reference should be Main -> DryrunParser ->QueryParserDriver, resulting a cleaner design.
I can review again if the suggested change makes sense.
> -dryrun does not work with set
> ------------------------------
>
> Key: PIG-1987
> URL: https://issues.apache.org/jira/browse/PIG-1987
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1987.patch
>
>
> The following script works
> {code}
> set default_parallel 10;
> import 'scripts/macro1.pig';
> import 'scripts/macro2.pig';
> wlogs = load 'clicks' as (url, pageid, timestamp);
> good = spam_filter(wlogs, url);
> {code}
> But if -dryrun is added to the command line it returns the error:
> {code}
> ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax error, unexpected symbol at or near 'set'
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1987) -dryrun does not work with set
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019581#comment-13019581 ]
Richard Ding commented on PIG-1987:
-----------------------------------
Test-patch result:
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 581 release audit warnings (more than the trunk's current 573 warnings).
{code}
The release audit warnings are html related.
> -dryrun does not work with set
> ------------------------------
>
> Key: PIG-1987
> URL: https://issues.apache.org/jira/browse/PIG-1987
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1987.patch
>
>
> The following script works
> {code}
> set default_parallel 10;
> import 'scripts/macro1.pig';
> import 'scripts/macro2.pig';
> wlogs = load 'clicks' as (url, pageid, timestamp);
> good = spam_filter(wlogs, url);
> {code}
> But if -dryrun is added to the command line it returns the error:
> {code}
> ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax error, unexpected symbol at or near 'set'
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1987) -dryrun does not work with set
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021822#comment-13021822 ]
Xuefu Zhang commented on PIG-1987:
----------------------------------
+1 to patch PIG-1987_1.patch
> -dryrun does not work with set
> ------------------------------
>
> Key: PIG-1987
> URL: https://issues.apache.org/jira/browse/PIG-1987
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1987.patch, PIG-1987_1.patch
>
>
> The following script works
> {code}
> set default_parallel 10;
> import 'scripts/macro1.pig';
> import 'scripts/macro2.pig';
> wlogs = load 'clicks' as (url, pageid, timestamp);
> good = spam_filter(wlogs, url);
> {code}
> But if -dryrun is added to the command line it returns the error:
> {code}
> ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax error, unexpected symbol at or near 'set'
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIG-1987) -dryrun does not work with set
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang reassigned PIG-1987:
--------------------------------
Assignee: Richard Ding (was: Xuefu Zhang)
> -dryrun does not work with set
> ------------------------------
>
> Key: PIG-1987
> URL: https://issues.apache.org/jira/browse/PIG-1987
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
>
> The following script works
> {code}
> set default_parallel 10;
> import 'scripts/macro1.pig';
> import 'scripts/macro2.pig';
> wlogs = load 'clicks' as (url, pageid, timestamp);
> good = spam_filter(wlogs, url);
> {code}
> But if -dryrun is added to the command line it returns the error:
> {code}
> ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax error, unexpected symbol at or near 'set'
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1987) -dryrun does not work with set
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1987:
------------------------------
Attachment: PIG-1987_1.patch
New patch made changes to address the review comments.
> -dryrun does not work with set
> ------------------------------
>
> Key: PIG-1987
> URL: https://issues.apache.org/jira/browse/PIG-1987
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1987.patch, PIG-1987_1.patch
>
>
> The following script works
> {code}
> set default_parallel 10;
> import 'scripts/macro1.pig';
> import 'scripts/macro2.pig';
> wlogs = load 'clicks' as (url, pageid, timestamp);
> good = spam_filter(wlogs, url);
> {code}
> But if -dryrun is added to the command line it returns the error:
> {code}
> ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax error, unexpected symbol at or near 'set'
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-1987) -dryrun does not work with set
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding resolved PIG-1987.
-------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Unit tests pass. Patch committed to trunk.
> -dryrun does not work with set
> ------------------------------
>
> Key: PIG-1987
> URL: https://issues.apache.org/jira/browse/PIG-1987
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1987.patch, PIG-1987_1.patch
>
>
> The following script works
> {code}
> set default_parallel 10;
> import 'scripts/macro1.pig';
> import 'scripts/macro2.pig';
> wlogs = load 'clicks' as (url, pageid, timestamp);
> good = spam_filter(wlogs, url);
> {code}
> But if -dryrun is added to the command line it returns the error:
> {code}
> ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax error, unexpected symbol at or near 'set'
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1987) -dryrun does not work with set
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1987:
------------------------------
Attachment: PIG-1987.patch
> -dryrun does not work with set
> ------------------------------
>
> Key: PIG-1987
> URL: https://issues.apache.org/jira/browse/PIG-1987
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1987.patch
>
>
> The following script works
> {code}
> set default_parallel 10;
> import 'scripts/macro1.pig';
> import 'scripts/macro2.pig';
> wlogs = load 'clicks' as (url, pageid, timestamp);
> good = spam_filter(wlogs, url);
> {code}
> But if -dryrun is added to the command line it returns the error:
> {code}
> ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax error, unexpected symbol at or near 'set'
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira