You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pdfbox.apache.org by ti...@apache.org on 2015/01/16 22:36:49 UTC

svn commit: r1652528 - /pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java

Author: tilman
Date: Fri Jan 16 21:36:49 2015
New Revision: 1652528

URL: http://svn.apache.org/r1652528
Log:
PDFBOX-2576: classes with private constructor can be final; remove uneeded assignments

Modified:
    pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java

Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java?rev=1652528&r1=1652527&r2=1652528&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java Fri Jan 16 21:36:49 2015
@@ -701,7 +701,7 @@ public class CMapParser
 
     private String createStringFromBytes(byte[] bytes) throws IOException
     {
-        String retval = null;
+        String retval;
         if (bytes.length == 1)
         {
             retval = new String(bytes, "ISO-8859-1");
@@ -740,7 +740,7 @@ public class CMapParser
     /**
      * Internal class.
      */
-    private class LiteralName
+    private final class LiteralName
     {
         private String name;
 
@@ -753,7 +753,7 @@ public class CMapParser
     /**
      * Internal class.
      */
-    private class Operator
+    private final class Operator
     {
         private String op;