You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "eugenegujing (via GitHub)" <gi...@apache.org> on 2026/08/30 02:56:33 UTC
[PR] test(workflow-core): extend IcebergUtil test coverage [texera]
eugenegujing opened a new pull request, #8122:
URL: https://github.com/apache/texera/pull/8122
### What changes were proposed in this PR?
This PR extends test coverage for `IcebergUtil` error and edge contracts without changing production behavior.
| Contract | Added coverage |
| --- | --- |
| Amber `ANY` type | Rejects it with the documented `IllegalArgumentException` |
| Unsupported Iceberg primitive | Rejects `DateType` with the unsupported-type error |
| Catalog without namespace support | Reports the concrete catalog class before attempting table operations |
| Existing table with override enabled | Recreates the table and persists the replacement schema |
| Existing table with override disabled | Raises `AlreadyExistsException` and preserves the original schema |
| Missing table metadata | Returns `None` through a real `HadoopCatalog` |
| Catalog load failure | Returns `None` when `loadTable` raises another runtime exception |
### Any related issues, documentation, discussions?
Closes #8120
### How was this PR tested?
The complete `IcebergUtilSpec` was run with JDK 17 while excluding an unrelated failing DAO test classpath:
```bash
JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home PATH=/Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home/bin:/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin sbt -Dsbt.log.noformat=true \
'set WorkflowCore / Test / sources := Seq((WorkflowCore / baseDirectory).value / "src/test/scala/org/apache/texera/amber/util/IcebergUtilSpec.scala", (WorkflowCore / baseDirectory).value / "src/test/java/org/apache/texera/common/tags/NonParallelTest.java")' \
'set WorkflowCore / Test / internalDependencyClasspath := (WorkflowCore / Compile / fullClasspath).value' \
'WorkflowCore/testOnly org.apache.texera.amber.util.IcebergUtilSpec' \
'WorkflowCore/Test/scalafmtCheck'
```
Result: 23 tests passed and the target test source passed the formatting check.
`git diff --check` also passed.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5.6-sol)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-core): extend IcebergUtil test coverage [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8122:
URL: https://github.com/apache/texera/pull/8122#issuecomment-5466348811
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`
You can notify them by mentioning `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-core): extend IcebergUtil test coverage [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8122:
URL: https://github.com/apache/texera/pull/8122#issuecomment-5466370805
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 5 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `b8f6c5b` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33289134274)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 381 | 0.233 | 24,546/35,020/35,020 us | 🔴 -8.4% / 🔴 +137.2% |
| 🔴 | bs=100 sw=10 sl=64 | 781 | 0.476 | 122,935/185,362/185,362 us | 🔴 +27.5% / 🔴 +83.6% |
| ⚪ | bs=1000 sw=10 sl=64 | 925 | 0.565 | 1,068,975/1,135,274/1,135,274 us | ⚪ within ±5% / 🔴 -16.8% |
<details><summary>Baseline details</summary>
Latest main `b8f6c5b` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 381 tuples/sec | 416 tuples/sec | 842.25 tuples/sec | -8.4% | -54.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.233 MB/s | 0.254 MB/s | 0.514 MB/s | -8.3% | -54.7% |
| bs=10 sw=10 sl=64 | p50 | 24,546 us | 24,649 us | 11,860 us | -0.4% | +107.0% |
| bs=10 sw=10 sl=64 | p95 | 35,020 us | 34,249 us | 14,764 us | +2.3% | +137.2% |
| bs=10 sw=10 sl=64 | p99 | 35,020 us | 34,249 us | 17,870 us | +2.3% | +96.0% |
| bs=100 sw=10 sl=64 | throughput | 781 tuples/sec | 822 tuples/sec | 1,084 tuples/sec | -5.0% | -27.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.476 MB/s | 0.502 MB/s | 0.662 MB/s | -5.2% | -28.0% |
| bs=100 sw=10 sl=64 | p50 | 122,935 us | 122,467 us | 94,616 us | +0.4% | +29.9% |
| bs=100 sw=10 sl=64 | p95 | 185,362 us | 145,387 us | 100,981 us | +27.5% | +83.6% |
| bs=100 sw=10 sl=64 | p99 | 185,362 us | 145,387 us | 108,141 us | +27.5% | +71.4% |
| bs=1000 sw=10 sl=64 | throughput | 925 tuples/sec | 923 tuples/sec | 1,112 tuples/sec | +0.2% | -16.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.565 MB/s | 0.563 MB/s | 0.679 MB/s | +0.4% | -16.7% |
| bs=1000 sw=10 sl=64 | p50 | 1,068,975 us | 1,090,834 us | 930,623 us | -2.0% | +14.9% |
| bs=1000 sw=10 sl=64 | p95 | 1,135,274 us | 1,113,435 us | 974,308 us | +2.0% | +16.5% |
| bs=1000 sw=10 sl=64 | p99 | 1,135,274 us | 1,113,435 us | 1,002,806 us | +2.0% | +13.2% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,524.49,200,128000,381,0.233,24546.48,35019.56,35019.56
1,100,10,64,20,2561.83,2000,1280000,781,0.476,122934.65,185361.53,185361.53
2,1000,10,64,20,21612.55,20000,12800000,925,0.565,1068975.11,1135274.00,1135274.00
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-core): extend IcebergUtil test coverage [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8122:
URL: https://github.com/apache/texera/pull/8122#issuecomment-5466358816
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8122?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.70%. Comparing base ([`04b213d`](https://app.codecov.io/gh/apache/texera/commit/04b213d9aa0d7310cfecefaab50cc4f9323e3e58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5fd31b9`](https://app.codecov.io/gh/apache/texera/commit/5fd31b97c5cf7ddef0500e6fe690338ffc85a0b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8122 +/- ##
=========================================
Coverage 93.70% 93.70%
Complexity 4741 4741
=========================================
Files 1181 1181
Lines 47874 47874
Branches 5323 5323
=========================================
Hits 44861 44861
Misses 1578 1578
Partials 1435 1435
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [04b213d](https://app.codecov.io/gh/apache/texera/commit/04b213d9aa0d7310cfecefaab50cc4f9323e3e58?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.71% <ø> (ø)` | | Carriedforward from [04b213d](https://app.codecov.io/gh/apache/texera/commit/04b213d9aa0d7310cfecefaab50cc4f9323e3e58?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [04b213d](https://app.codecov.io/gh/apache/texera/commit/04b213d9aa0d7310cfecefaab50cc4f9323e3e58?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [04b213d](https://app.codecov.io/gh/apache/texera/commit/04b213d9aa0d7310cfecefaab50cc4f9323e3e58?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.18% <ø> (ø)` | | Carriedforward from [04b213d](https://app.codecov.io/gh/apache/texera/commit/04b213d9aa0d7310cfecefaab50cc4f9323e3e58?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.87% <ø> (ø)` | | Carriedforward from [04b213d](https://app.codecov.io/gh/apache/texera/commit/04b213d9aa0d7310cfecefaab50cc4f9323e3e58?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [04b213d](https://app.codecov.io/gh/apache/texera/commit/04b213d9aa0d7310cfecefaab50cc4f9323e3e58?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8122?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-core): extend IcebergUtil test coverage [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8122:
URL: https://github.com/apache/texera/pull/8122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org