[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on a change in pull request #8: [YUNIKORN-16] add UPDATE_NODE_CAPACITY action in order to report node resource updates

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #8: [YUNIKORN-16] add UPDATE_NODE_CAPACITY action in order to report node resource updates
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/8#discussion_r394016359
 
 

 ##########
 File path: si.proto
 ##########
 @@ -365,6 +365,9 @@ message UpdateNodeInfo {
     // From Draining state to SCHEDULABLE state.
     // If node is not in draining state, error will be thrown
     DRAIN_TO_SCHEDULABLE = 3;
+
+    // Update node total allocatable resources.
+    UPDATE_NODE_CAPACITY = 4;
 
 Review comment:
   Two things:
   * the `noop` option is not needed: why would we want to send a message that is ignored and has no response
   * we should really replace the `noop` with a generic `update`, we should not need a new message action when we want to update other values later.
   
   I do think the other names are also need a clean up but that might be better for a separate jira (remove NODE in DRAIN_NODE, change DRAIN_TO_SCHEDULABLE to SCHEDULABLE) to make it more consistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org