You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2020/06/27 12:23:00 UTC

[whimsy] branch master updated: Use shorthand keys

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 8cfb8bf  Use shorthand keys
8cfb8bf is described below

commit 8cfb8bf17fde79abf9d2699023e22f3a241163fb
Author: Sebb <se...@apache.org>
AuthorDate: Sat Jun 27 13:22:52 2020 +0100

    Use shorthand keys
---
 lib/whimsy/asf/svn.rb | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/whimsy/asf/svn.rb b/lib/whimsy/asf/svn.rb
index a5ebcdb..5ec8ce7 100644
--- a/lib/whimsy/asf/svn.rb
+++ b/lib/whimsy/asf/svn.rb
@@ -478,7 +478,7 @@ module ASF
         pass = env.password.dup.untaint
         # checkout committers/board (this does not have many files currently)
         out, err = self.svn('checkout', [ciURL, tmpdir.untaint],
-          {args: ['--quiet', '--depth', 'files'],
+          {args: '--quiet', depth: 'files'],
            user: user, password: pass})
 
         raise Exception.new("Checkout of board folder failed: #{err}") unless out
@@ -494,7 +494,7 @@ module ASF
 
         # commit the updated file
         out, err = self.svn('commit', [file, tmpdir.untaint],
-          {args: ['--quiet', '--message', msg],
+          {args: '--quiet', msg: msg,
            user: user, password: pass})
 
         raise Exception.new("Update of committee-info.txt failed: #{err}") unless out
@@ -531,7 +531,7 @@ module ASF
       begin
         # create an empty checkout
         self.svn_('checkout', [self.getInfoItem(dir,'url'), tmpdir], _,
-          {args: ['--depth', 'empty'], env: env})
+          {depth: 'empty', env: env})
 
         # retrieve the file to be updated (may not exist)
         if basename
@@ -575,7 +575,7 @@ module ASF
         else
           # commit the changes
           rc = self.svn_('commit', tmpfile || tmpdir, _,
-             {args: ['--message', msg.untaint], env: env})
+             {msg: msg.untaint, env: env})
         end
 
         # fail if there are pending changes
@@ -697,7 +697,7 @@ module ASF
       begin
 
         # create an empty checkout
-        rc = self.svn_('checkout', [parenturl, tmpdir], _, {args: ['--depth', 'empty'], env: env})
+        rc = self.svn_('checkout', [parenturl, tmpdir], _, {depth: 'empty', env: env})
         raise "svn failure #{rc} checkout #{parenturl}" unless rc == 0
 
         # checkout the file