You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/05/22 16:59:05 UTC
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6951
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
IMPALA-5350: Tidy up thread groups for finst exec threads
Put all per-finst threads (profile report, exec thread, async build
thread) together in one group "fragment-execution", and add finst ID to
all their names.
Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Testing: eyeballed with a join query.
---
M be/src/exec/blocking-join-node.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/query-state.cc
4 files changed, 15 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/6951/1
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 1:
Good idea - done with both.
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
IMPALA-5350: Tidy up thread groups for finst exec threads
Put all per-finst threads (profile report, exec thread, async build
thread, scanner threads) together in one group "fragment-execution", and
add finst ID to all their names.
Remove -<tid> suffix from thread names and add a separate column with it
to /threadz web page.
Testing: eyeballed with a join query.
Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Reviewed-on: http://gerrit.cloudera.org:8080/6951
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/kudu-scan-node.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/query-state.cc
M be/src/util/thread.cc
M www/thread-group.tmpl
8 files changed, 40 insertions(+), 26 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Henry Robinson: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/fragment-instance-state.cc
File be/src/runtime/fragment-instance-state.cc:
PS2, Line 232: &FragmentInstanceState::ReportProfileThread, this
you rewrote the other cases to use a lambda here. i don't have a strong preference either way, but just wondering if there's a reason for the inconsistency?
http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
PS2, Line 303: &QueryState::ExecFInstance, this, fis
same
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
IMPALA-5350: Tidy up thread groups for finst exec threads
Put all per-finst threads (profile report, exec thread, async build
thread, scanner threads) together in one group "fragment-execution", and
add finst ID to all their names.
Remove -<tid> suffix from thread names and add a separate column with it
to /threadz web page.
Testing: eyeballed with a join query.
Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/kudu-scan-node.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/query-state.cc
M be/src/util/thread.cc
M www/thread-group.tmpl
8 files changed, 37 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/6951/2
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 2: Code-Review+1
Thanks! So much better.
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 1:
Patch looks fine, just some random thoughts:
* A fragment can still have many join-build threads, do you think it make sense to add the plan node id?
* The scanner threads have a similar issue. Want to fix it now or later?
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6951
to look at the new patch set (#3).
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
IMPALA-5350: Tidy up thread groups for finst exec threads
Put all per-finst threads (profile report, exec thread, async build
thread, scanner threads) together in one group "fragment-execution", and
add finst ID to all their names.
Remove -<tid> suffix from thread names and add a separate column with it
to /threadz web page.
Testing: eyeballed with a join query.
Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/kudu-scan-node.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/query-state.cc
M be/src/util/thread.cc
M www/thread-group.tmpl
8 files changed, 40 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/6951/3
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 1:
Ping - this is a minor, but useful, debugging improvement.
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Carry +2
http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/fragment-instance-state.cc
File be/src/runtime/fragment-instance-state.cc:
PS2, Line 232: [this]() { this->ReportProfileThread(); }));
> you rewrote the other cases to use a lambda here. i don't have a strong pre
The other example used bind(..), which to my eye is less readable than a lambda. This one didn't cross my threshold for readability, but I fixed it now :)
http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
PS2, Line 303: ad t(FragmentInstanceState::FINST_THR
> same
Done
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/fragment-instance-state.cc
File be/src/runtime/fragment-instance-state.cc:
PS2, Line 232: &FragmentInstanceState::ReportProfileThread, this
> The other example used bind(..), which to my eye is less readable than a la
I was talking about the non-bind one (kudu-scan-node). anyway, either way is fine.
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/666/
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No