[GitHub] [incubator-superset] villebro commented on a change in pull request #8229: [POC] add echarts scatter

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8229: [POC] add echarts scatter
URL: https://github.com/apache/incubator-superset/pull/8229#discussion_r324804169
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -2765,6 +2765,15 @@ def get_data(self, df):
         return self.nest_values(levels)
 
 
+class EchartsScatter(BubbleViz):
 
 Review comment:
   @kristw is there already a working plan for migrating some of the more complex legacy viz's to the new api, namely the ones that rely on Pandas functionality? Is the plan to do that logic in JS, och making the heavy lifting in the backend? I anticipate quite a bit of work there, and can lend a hand if necessary, especially if the new API needs new functionality..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org