You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "superhx (via GitHub)" <gi...@apache.org> on 2023/04/19 01:49:58 UTC
[GitHub] [rocketmq] superhx commented on a diff in pull request #6606: optimized tips when sending large size message and bug fix
superhx commented on code in PR #6606:
URL: https://github.com/apache/rocketmq/pull/6606#discussion_r1170723615
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -534,6 +535,13 @@ public void executeAsyncMessageSend(Runnable runnable, final Message msg, final
boolean isSemaphoreAsyncNumAquired = false;
boolean isSemaphoreAsyncSizeAquired = false;
int msgLen = msg.getBody() == null ? 1 : msg.getBody().length;
+ if (msgLen > this.getDefaultMQProducer().getBackPressureForAsyncSendSize()) {
Review Comment:
I think origin checks is correct:
- when inflight messages buffer is larger than backPressureForAsyncSendSize, it suggests client send too fast than broker can take , client should fast return RemotingTooMuchRequestException.
- when single message serialized size is larger than maxMessageSize, client should return MESSAGE_ILLEGAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org