You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ByteYue (via GitHub)" <gi...@apache.org> on 2024/06/11 05:55:27 UTC

[PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

ByteYue opened a new pull request, #36104:
URL: https://github.com/apache/doris/pull/36104

   ## Proposed changes
   
   <!--Describe your changes.-->
   
   Previously the default vault info would only be refreshed when user tries to set default storage vault. The default vault info might be lost if the FE crashed and restarted. This pr tries to add one routine work which would refresh the default vault info.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36104:
URL: https://github.com/apache/doris/pull/36104#issuecomment-2159927166

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 174532 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit d94bbec591951e1f3b3c39709e21f8b853d06e87, data reload: false
   
   query1	954	391	383	383
   query2	6463	2434	2357	2357
   query3	6634	204	205	204
   query4	19815	17465	17407	17407
   query5	3550	454	442	442
   query6	234	163	163	163
   query7	4584	296	287	287
   query8	300	278	283	278
   query9	8838	2400	2356	2356
   query10	560	300	281	281
   query11	10673	10192	10111	10111
   query12	127	92	90	90
   query13	1656	374	366	366
   query14	10143	7794	7653	7653
   query15	225	191	185	185
   query16	7618	262	269	262
   query17	1907	532	530	530
   query18	1608	275	267	267
   query19	210	145	148	145
   query20	92	81	79	79
   query21	212	131	132	131
   query22	4302	4058	4049	4049
   query23	33868	33711	33480	33480
   query24	10989	2967	3014	2967
   query25	600	362	379	362
   query26	837	154	154	154
   query27	2401	329	338	329
   query28	6213	2123	2119	2119
   query29	885	638	618	618
   query30	267	152	149	149
   query31	955	782	737	737
   query32	99	51	54	51
   query33	785	279	264	264
   query34	1119	477	490	477
   query35	740	665	630	630
   query36	1115	945	1005	945
   query37	152	72	74	72
   query38	2965	2877	2837	2837
   query39	899	827	832	827
   query40	211	129	138	129
   query41	54	54	55	54
   query42	108	105	108	105
   query43	609	584	533	533
   query44	1201	714	729	714
   query45	194	157	169	157
   query46	1087	734	710	710
   query47	1853	1766	1769	1766
   query48	369	295	299	295
   query49	848	396	402	396
   query50	759	391	389	389
   query51	6893	6697	6695	6695
   query52	112	92	90	90
   query53	349	281	275	275
   query54	879	440	466	440
   query55	79	74	72	72
   query56	268	250	253	250
   query57	1124	1037	1071	1037
   query58	250	252	226	226
   query59	3402	3413	3233	3233
   query60	281	255	255	255
   query61	102	87	88	87
   query62	589	461	446	446
   query63	316	291	288	288
   query64	8772	2318	1703	1703
   query65	3268	3158	3091	3091
   query66	745	318	326	318
   query67	15617	14986	15279	14986
   query68	4484	527	532	527
   query69	555	431	341	341
   query70	1119	1056	1041	1041
   query71	387	263	267	263
   query72	6814	5657	5491	5491
   query73	742	330	319	319
   query74	5816	5550	5467	5467
   query75	3318	2636	2702	2636
   query76	2073	931	905	905
   query77	415	289	290	289
   query78	10407	9925	10028	9925
   query79	2603	507	510	507
   query80	1029	457	498	457
   query81	558	218	220	218
   query82	1063	100	97	97
   query83	262	167	161	161
   query84	231	86	82	82
   query85	1025	275	277	275
   query86	446	305	318	305
   query87	3250	3067	3150	3067
   query88	3415	2356	2359	2356
   query89	478	375	375	375
   query90	1618	186	183	183
   query91	123	93	93	93
   query92	62	47	52	47
   query93	1731	496	492	492
   query94	1060	189	183	183
   query95	388	318	308	308
   query96	580	266	271	266
   query97	3138	3024	3025	3024
   query98	210	199	199	199
   query99	1121	855	849	849
   Total cold run time: 266454 ms
   Total hot run time: 174532 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36104:
URL: https://github.com/apache/doris/pull/36104#issuecomment-2159854332

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36104:
URL: https://github.com/apache/doris/pull/36104#issuecomment-2159935139

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.19 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit d94bbec591951e1f3b3c39709e21f8b853d06e87, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.04	0.04
   query3	0.24	0.04	0.05
   query4	1.68	0.08	0.08
   query5	0.52	0.47	0.48
   query6	1.12	0.73	0.73
   query7	0.02	0.01	0.02
   query8	0.05	0.04	0.05
   query9	0.55	0.49	0.50
   query10	0.55	0.55	0.55
   query11	0.15	0.12	0.11
   query12	0.15	0.12	0.11
   query13	0.59	0.60	0.61
   query14	0.81	0.80	0.77
   query15	0.83	0.81	0.81
   query16	0.38	0.37	0.36
   query17	1.04	0.97	1.00
   query18	0.22	0.23	0.26
   query19	1.84	1.83	1.71
   query20	0.01	0.01	0.01
   query21	15.41	0.64	0.63
   query22	3.93	6.98	2.42
   query23	18.40	1.43	1.35
   query24	2.18	0.22	0.21
   query25	0.16	0.09	0.08
   query26	0.26	0.18	0.18
   query27	0.08	0.09	0.09
   query28	13.20	1.01	0.99
   query29	12.61	3.33	3.28
   query30	0.26	0.07	0.06
   query31	2.85	0.40	0.38
   query32	3.28	0.48	0.47
   query33	2.83	2.91	2.99
   query34	17.15	4.44	4.46
   query35	4.53	4.49	4.47
   query36	0.66	0.48	0.47
   query37	0.18	0.16	0.15
   query38	0.15	0.14	0.14
   query39	0.04	0.04	0.03
   query40	0.17	0.16	0.15
   query41	0.10	0.05	0.05
   query42	0.06	0.05	0.05
   query43	0.04	0.03	0.04
   Total cold run time: 109.4 s
   Total hot run time: 31.19 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36104:
URL: https://github.com/apache/doris/pull/36104#issuecomment-2159911245

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39676 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit d94bbec591951e1f3b3c39709e21f8b853d06e87, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17630	4313	4228	4228
   q2	2022	196	192	192
   q3	10460	1141	1142	1141
   q4	10191	763	751	751
   q5	7449	2674	2673	2673
   q6	222	135	136	135
   q7	957	603	603	603
   q8	9222	2048	2082	2048
   q9	9040	6500	6442	6442
   q10	9003	3685	3714	3685
   q11	462	243	244	243
   q12	525	232	228	228
   q13	18870	2966	2951	2951
   q14	274	214	218	214
   q15	523	482	475	475
   q16	506	396	366	366
   q17	950	612	635	612
   q18	7908	7441	7445	7441
   q19	7065	1463	1415	1415
   q20	671	327	329	327
   q21	4946	3176	3856	3176
   q22	381	330	330	330
   Total cold run time: 119277 ms
   Total hot run time: 39676 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4329	4223	4258	4223
   q2	369	280	266	266
   q3	3047	2893	2894	2893
   q4	1981	1741	1711	1711
   q5	5509	5503	5426	5426
   q6	221	131	134	131
   q7	2253	1853	1777	1777
   q8	3264	3418	3400	3400
   q9	8706	8697	8721	8697
   q10	4153	3688	3779	3688
   q11	624	503	499	499
   q12	792	637	610	610
   q13	17144	3152	3153	3152
   q14	308	292	288	288
   q15	511	493	500	493
   q16	487	449	443	443
   q17	1798	1516	1506	1506
   q18	8062	7951	7761	7761
   q19	4613	1703	1678	1678
   q20	2160	1900	1880	1880
   q21	5126	4816	4738	4738
   q22	654	534	558	534
   Total cold run time: 76111 ms
   Total hot run time: 55794 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #36104:
URL: https://github.com/apache/doris/pull/36104#issuecomment-2159854390

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36104:
URL: https://github.com/apache/doris/pull/36104#issuecomment-2162199859

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36104:
URL: https://github.com/apache/doris/pull/36104#issuecomment-2162199807

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](Vault) Refresh default storage vault info when doing instance check in FE [doris]

Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko merged PR #36104:
URL: https://github.com/apache/doris/pull/36104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org