You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2024/11/24 07:23:22 UTC
[PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]
frankvicky opened a new pull request, #17931:
URL: https://github.com/apache/kafka/pull/17931
JIRA: KAFKA-18067
To avoid leaking producers, we should add a 'closed` flag to `StreamProducer` indicating whether we should reset prouder.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #17931:
URL: https://github.com/apache/kafka/pull/17931#issuecomment-2694932880
This PR introduced a regression for EOS, and was reverted for `4.0.0` release.
https://github.com/apache/kafka/pull/19078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman merged PR #17931:
URL: https://github.com/apache/kafka/pull/17931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on PR #17931:
URL: https://github.com/apache/kafka/pull/17931#issuecomment-2521705409
LGTM overall, but I'm wondering if some more unit test cases would better add to reflect the original bug? Up to @frankvicky and @ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #17931:
URL: https://github.com/apache/kafka/pull/17931#issuecomment-2522265195
Hi @guozhangwang @ableegoldman
Thanks for review.
I have add a unit test for this case, PTAL 🐧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #17931:
URL: https://github.com/apache/kafka/pull/17931#issuecomment-2529891486
Merged to trunk. Thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org