You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/07/26 21:44:57 UTC
[GitHub] [guacamole-client] jmuehlner opened a new pull request, #747: GUACAMOLE-1629: Keep track of iterated identifiers when recursing connection group tree looking for KSM attribute to ensure no infinite loop.
jmuehlner opened a new pull request, #747:
URL: https://github.com/apache/guacamole-client/pull/747
This is a fix for a bug introduced in https://github.com/apache/guacamole-client/pull/739.
In testing, I made the unfortunate assumption that once the loop hit the root connection group, the `getConnectionGroup()` call would return `null` since this is what happened with my setup.
In fact, there's nothing in the API that explicitly guarantees that there can't be cycles. Later testing determined that this can actually happen when using sharing profiles.
This change modifies the loop so that it keeps track of all iterated identifiers. If any identifier is ever seen twice, it knows that a cycle has been hit, and immediately exits.
I've verified that this change fixes the infinite recursion issue seen when using sharing profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper merged pull request #747: GUACAMOLE-1629: Keep track of iterated identifiers when recursing connection group tree looking for KSM attribute to ensure no infinite loop.
Posted by GitBox <gi...@apache.org>.
mike-jumper merged PR #747:
URL: https://github.com/apache/guacamole-client/pull/747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org