You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2017/02/28 15:23:55 UTC

Review Request 57148: HiveView 2.0: save as HDFS shows success message on error

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57148/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20236
    https://issues.apache.org/jira/browse/AMBARI-20236


Repository: ambari


Description
-------

There is no error thrown from the backend in case of failure. Now handle this case.


Diffs
-----

  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobController.java bd3bb23 
  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobException.java PRE-CREATION 
  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java 6eedcca 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobController.java 0b21a18 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobException.java PRE-CREATION 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java c5479e7 

Diff: https://reviews.apache.org/r/57148/diff/


Testing
-------

Manually Tested


Thanks,

Gaurav Nagar

Re: Review Request 57148: HiveView 2.0: save as HDFS shows success message on error

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57148/#review167214
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 28, 2017, 3:23 p.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57148/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 3:23 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20236
>     https://issues.apache.org/jira/browse/AMBARI-20236
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is no error thrown from the backend in case of failure. Now handle this case.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobController.java bd3bb23 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobException.java PRE-CREATION 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java 6eedcca 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobController.java 0b21a18 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobException.java PRE-CREATION 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java c5479e7 
> 
> 
> Diff: https://reviews.apache.org/r/57148/diff/1/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 57148: HiveView 2.0: save as HDFS shows success message on error

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57148/#review167224
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 28, 2017, 3:23 p.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57148/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 3:23 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20236
>     https://issues.apache.org/jira/browse/AMBARI-20236
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is no error thrown from the backend in case of failure. Now handle this case.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobController.java bd3bb23 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/backgroundjobs/BackgroundJobException.java PRE-CREATION 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java 6eedcca 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobController.java 0b21a18 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/backgroundjobs/BackgroundJobException.java PRE-CREATION 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java c5479e7 
> 
> 
> Diff: https://reviews.apache.org/r/57148/diff/1/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>